fix: Address reviewer feedback - fix composition.utils.ts and remove console statements

- Add error handling to composition.utils.ts (third file with same bug)
- Remove all 9 console.log/warn/error statements (codebase has zero console logs)
- Keep only user-facing showToast notifications for actionable errors
- Silent error recovery for corrupted storage data

Author: sanks011

src/cohort-builder.utils.ts

@@ -123,7 +123,6 @@ export const addToHistory = (description: string, patients: Patient[], parameter
   try {
     // Validate inputs
     if (!Array.isArray(patients) || typeof parameters !== 'object') {
-      console.warn('[Cohort Builder] Invalid input to addToHistory');
       return false;
     }
 
@@ -139,7 +138,6 @@ export const addToHistory = (description: string, patients: Patient[], parameter
         const parsed = JSON.parse(storedData);
         oldHistory = Array.isArray(parsed) ? parsed : [];
       } catch (parseError) {
-        console.error('[Cohort Builder] Corrupted history data, resetting:', parseError);
         // Reset corrupted data
         window.sessionStorage.removeItem(STORAGE_KEY);
         oldHistory = [];
@@ -161,17 +159,10 @@ export const addToHistory = (description: string, patients: Patient[], parameter
     try {
       const serialized = JSON.stringify(newHistory);
 
-      // Warn if approaching limits (~4MB threshold)
-      if (serialized.length > 4 * 1024 * 1024) {
-        console.warn('[Cohort Builder] Search history approaching storage limits');
-      }
-
       window.sessionStorage.setItem(STORAGE_KEY, serialized);
       return true;
     } catch (storageError) {
       if (storageError.name === 'QuotaExceededError') {
-        console.error('[Cohort Builder] Storage quota exceeded, clearing old history');
-
         // Fallback: Keep only last 10 items
         const reducedHistory = newHistory.slice(-10);
         try {
@@ -184,7 +175,6 @@ export const addToHistory = (description: string, patients: Patient[], parameter
           return true;
         } catch (retryError) {
           // Complete failure - disable history
-          console.error('[Cohort Builder] Cannot save history, disabling feature', retryError);
           window.sessionStorage.removeItem(STORAGE_KEY);
           showToast({
             title: 'Search History Unavailable',
@@ -197,8 +187,7 @@ export const addToHistory = (description: string, patients: Patient[], parameter
       throw storageError; // Re-throw unexpected errors
     }
   } catch (error) {
-    // Log and continue - don't break searching if history fails
-    console.error('[Cohort Builder] Failed to add search to history:', error);
+    // Don't break searching if history fails
     showToast({
       title: 'History Error',
       kind: 'error',

src/components/composition/composition.utils.ts

@@ -23,16 +23,33 @@ export const createCompositionQuery = (compositionQuery: string) => {
 
   searchTokens.forEach((eachToken) => {
     if (eachToken.match(/\d/)) {
-      const history = JSON.parse(window.sessionStorage.getItem('openmrsHistory'));
-      const operandQuery = history[parseInt(eachToken) - 1];
-
-      const jsonRequestObject = operandQuery.parameters;
-      jsonRequestObject.customRowFilterCombination = formatFilterCombination(
-        jsonRequestObject.customRowFilterCombination,
-        query.rowFilters.length,
-      );
-      query.customRowFilterCombination += `(${jsonRequestObject.customRowFilterCombination})`;
-      query.rowFilters = query.rowFilters.concat(jsonRequestObject.rowFilters);
+      try {
+        const storedData = window.sessionStorage.getItem('openmrsHistory');
+        if (!storedData) {
+          return;
+        }
+
+        const history = JSON.parse(storedData);
+        if (!Array.isArray(history)) {
+          return;
+        }
+
+        const operandQuery = history[parseInt(eachToken) - 1];
+        if (!operandQuery?.parameters) {
+          return;
+        }
+
+        const jsonRequestObject = operandQuery.parameters;
+        jsonRequestObject.customRowFilterCombination = formatFilterCombination(
+          jsonRequestObject.customRowFilterCombination,
+          query.rowFilters.length,
+        );
+        query.customRowFilterCombination += `(${jsonRequestObject.customRowFilterCombination})`;
+        query.rowFilters = query.rowFilters.concat(jsonRequestObject.rowFilters);
+      } catch (error) {
+        // Skip invalid history entry
+        return;
+      }
     } else {
       query.customRowFilterCombination += ` ${eachToken} `;
     }

src/components/search-history/search-history.utils.ts

@@ -18,7 +18,6 @@ export const getSearchHistory = (): SearchHistoryItem[] => {
 
     // Validate that parsed data is an array
     if (!Array.isArray(history)) {
-      console.warn('[Cohort Builder] Invalid history data format, resetting');
       window.sessionStorage.removeItem(STORAGE_KEY);
       return [];
     }
@@ -38,12 +37,11 @@ export const getSearchHistory = (): SearchHistoryItem[] => {
 
     return searchHistory;
   } catch (error) {
-    console.error('[Cohort Builder] Error reading search history:', error);
     // Clear corrupted data to prevent repeated errors
     try {
       window.sessionStorage.removeItem(STORAGE_KEY);
     } catch (removeError) {
-      console.error('[Cohort Builder] Error clearing corrupted history:', removeError);
+      // Silent failure - storage access denied
     }
     return [];
   }