(fix) O3-3875: remove CDN dependency from schema editor ace configuration

Replace runtime CDN asset loading with bundled imports for ace-builds
mode, theme, and language tools. Set useWorker: false to prevent ace
from fetching the JSON worker file at runtime. Add gutter annotations
alongside existing markers so error icons render correctly in production.

Also remove unused isLoading prop, fix pre-existing logic bug in traverse
filter (|| -> &&), extract sub-components outside SchemaEditor, and
resolve SonarQube warnings in both schema-editor and form-editor.

Author: RajPrakash681

src/components/form-editor/form-editor.component.tsx

@@ -46,7 +46,7 @@ interface ErrorProps {
 }
 
 interface TranslationFnProps {
-  t: TFunction;
+  readonly t: TFunction;
 }
 
 interface MarkerProps extends IMarker {
@@ -223,15 +223,13 @@ const FormEditorContent: React.FC<TranslationFnProps> = ({ t }) => {
 
   const renderSchemaChanges = useCallback(() => {
     resetErrorMessage();
-    {
-      try {
-        const parsedJson: Schema = JSON.parse(stringifiedSchema);
-        updateSchema(parsedJson);
-        setStringifiedSchema(JSON.stringify(parsedJson, null, 2));
-      } catch (e) {
-        if (e instanceof Error) {
-          setInvalidJsonErrorMessage(e.message);
-        }
+    try {
+      const parsedJson: Schema = JSON.parse(stringifiedSchema);
+      updateSchema(parsedJson);
+      setStringifiedSchema(JSON.stringify(parsedJson, null, 2));
+    } catch (e) {
+      if (e instanceof Error) {
+        setInvalidJsonErrorMessage(e.message);
       }
     }
   }, [stringifiedSchema, updateSchema, resetErrorMessage]);
@@ -258,25 +256,11 @@ const FormEditorContent: React.FC<TranslationFnProps> = ({ t }) => {
     }
   }, [blockRenderingWithErrors, errors.length, renderSchemaChanges, selectedLanguageCode]);
 
-  const handleSchemaImport = (event: React.ChangeEvent<HTMLInputElement>) => {
+  const handleSchemaImport = async (event: React.ChangeEvent<HTMLInputElement>) => {
     const file = event.target.files[0];
-    const reader = new FileReader();
-
-    reader.onload = (e) => {
-      const result = e.target?.result;
-      if (typeof result === 'string') {
-        const fileContent: string = result;
-        const parsedJson: Schema = JSON.parse(fileContent);
-        setSchema(parsedJson);
-      } else if (result instanceof ArrayBuffer) {
-        const decoder = new TextDecoder();
-        const fileContent: string = decoder.decode(result);
-        const parsedJson: Schema = JSON.parse(fileContent);
-        setSchema(parsedJson);
-      }
-    };
-
-    reader.readAsText(file);
+    const fileContent = await file.text();
+    const parsedJson: Schema = JSON.parse(fileContent);
+    setSchema(parsedJson);
   };
 
   const downloadableSchema = useMemo(
@@ -316,7 +300,7 @@ const FormEditorContent: React.FC<TranslationFnProps> = ({ t }) => {
             <div className={styles.heading}>
               <span className={styles.tabHeading}>{t('schemaEditor', 'Schema editor')}</span>
               <div className={styles.topBtns}>
-                {!schema ? (
+                {schema ? null : (
                   <FileUploader
                     onChange={handleSchemaImport}
                     labelTitle=""
@@ -331,7 +315,7 @@ const FormEditorContent: React.FC<TranslationFnProps> = ({ t }) => {
                     iconDescription={t('importSchema', 'Import schema')}
                     name="form-import"
                   />
-                ) : null}
+                )}
                 {isNewSchema && !schema ? (
                   <Button kind="ghost" onClick={inputDummySchema}>
                     {t('inputDummySchema', 'Input dummy schema')}
@@ -376,7 +360,7 @@ const FormEditorContent: React.FC<TranslationFnProps> = ({ t }) => {
                     kind="ghost"
                     onClick={handleCopySchema}
                   />
-                  <a download={`${form?.name}.json`} href={window.URL.createObjectURL(downloadableSchema)}>
+                  <a download={`${form?.name}.json`} href={globalThis.URL.createObjectURL(downloadableSchema)}>
                     <IconButton
                       enterDelayInMs={defaultEnterDelayInMs}
                       kind="ghost"
@@ -398,7 +382,6 @@ const FormEditorContent: React.FC<TranslationFnProps> = ({ t }) => {
             <div className={styles.editorContainer}>
               <SchemaEditor
                 errors={errors}
-                isLoading={isLoadingFormOrSchema}
                 onSchemaChange={handleSchemaChange}
                 setErrors={setErrors}
                 setValidationOn={setValidationOn}
@@ -460,7 +443,9 @@ const FormEditorContent: React.FC<TranslationFnProps> = ({ t }) => {
 function BackButton({ t }: TranslationFnProps) {
   return (
     <div className={styles.backButton}>
-      <ConfigurableLink to={window.getOpenmrsSpaBase() + 'form-builder'}>
+      <ConfigurableLink
+        to={(globalThis as unknown as { getOpenmrsSpaBase: () => string }).getOpenmrsSpaBase() + 'form-builder'}
+      >
         <Button
           kind="ghost"
           renderIcon={(props) => <ArrowLeft size={24} {...props} />}