pr test fixes

Author: pirupius

__mocks__/forms/rfe-forms/component-art.json

@@ -43,7 +43,7 @@
                 },
                 {
                   "type": "js_expression",
-                  "failsWhenExpression": "(new moment(encDate)).isBefore((new moment(myValue)), 'day') || (new moment(encDate)).isSame((new moment(myValue)), 'day')",
+                  "failsWhenExpression": "dayjs(encDate).isBefore(dayjs(myValue), 'day') || dayjs(encDate).isSame(dayjs(myValue), 'day')",
                   "message": "Date should be before the encounter date."
                 }
               ]
@@ -114,7 +114,7 @@
                 },
                 {
                   "type": "js_expression",
-                  "failsWhenExpression": "(new moment(encDate)).isBefore((new moment(myValue)), 'day') || (new moment(encDate)).isSame((new moment(myValue)), 'day')",
+                  "failsWhenExpression": "dayjs(encDate).isBefore(dayjs(myValue), 'day') || dayjs(encDate).isSame(dayjs(myValue), 'day')",
                   "message": "ARV start date should be before the encounter date."
                 }
               ]
@@ -134,7 +134,7 @@
                 },
                 {
                   "type": "js_expression",
-                  "failsWhenExpression": "(new moment(encDate)).isBefore((new moment(myValue)), 'day') || (new moment(encDate)).isSame((new moment(myValue)), 'day')",
+                  "failsWhenExpression": "dayjs(encDate).isBefore(dayjs(myValue), 'day') || dayjs(encDate).isSame(dayjs(myValue), 'day')",
                   "message": "ARV start date should be before the encounter date."
                 }
               ]
@@ -154,7 +154,7 @@
                 },
                 {
                   "type": "js_expression",
-                  "failsWhenExpression": "(new moment(encDate)).isBefore((new moment(myValue)), 'day') || (new moment(encDate)).isSame((new moment(myValue)), 'day')",
+                  "failsWhenExpression": "dayjs(encDate).isBefore(dayjs(myValue), 'day') || dayjs(encDate).isSame(dayjs(myValue), 'day')",
                   "message": "ARV start date should be before the encounter date."
                 }
               ]

src/hooks/useInitialValues.test.ts

@@ -67,7 +67,7 @@ describe('useInitialValues', () => {
 
     const { result } = renderHook(() => useInitialValues(formProcessor, false, context));
 
-    await waitFor(() => expect(result.current.isLoadingInitialValues).toBe(true));
+    await waitFor(() => expect(result.current.isLoadingInitialValues).toBe(false));
 
     expect(formProcessor.getInitialValues).toHaveBeenCalledWith(context);
     expect(result.current.initialValues).toEqual(mockInitialValues);

src/utils/expression-runner.test.ts

@@ -387,7 +387,7 @@ describe('Expression runner', () => {
     // setup - use a known date 30 days ago
     const thirtyDaysAgo = new Date();
     thirtyDaysAgo.setDate(thirtyDaysAgo.getDate() - 30);
-    const dateOfBirthString = thirtyDaysAgo.toISOString().split('T')[0];
+    const dateOfBirthString = thirtyDaysAgo.toLocaleDateString('en-CA'); // en-CA produces YYYY-MM-DD in local time
     valuesMap['dateOfBirth'] = dateOfBirthString;
 
     // Calculate days difference