code review

Author: CynthiaKamau

src/components/inputs/ui-select-extended/ui-select-extended.component.tsx

@@ -170,7 +170,7 @@ const UiSelectExtended: React.FC<FormFieldInputProps> = ({ field, errors, warnin
             selectedItem={selectedItem}
             placeholder={isSearchable ? t('search', 'Search') + '...' : null}
             shouldFilterItem={({ item, inputValue }) => {
-              if (!inputValue || items.find((item) => item.uuid == field.value)) {
+              if (!inputValue) {
                 // Carbon's initial call at component mount
                 return true;
               }

src/hooks/useFormJson.ts

@@ -125,10 +125,10 @@ async function refineFormJson(
 ): Promise<FormSchema> {
   removeInlineSubForms(formJson, formSessionIntent);
   // apply form schema transformers
-  for (let transformer of schemaTransformers) {
-    const draftForm = await transformer.transform(formJson);
-    formJson = draftForm;
-  }
+  schemaTransformers.reduce(
+    async (form, transformer) => Promise.resolve(transformer.transform(await form)),
+    Promise.resolve(formJson),
+  );
   setEncounterType(formJson);
   return applyFormIntent(formSessionIntent, formJson);
 }

src/hooks/usePersonAttributes.tsx

@@ -1,16 +1,17 @@
 import { openmrsFetch, type PersonAttribute, restBaseUrl } from '@openmrs/esm-framework';
 import { useEffect, useState } from 'react';
+import { type FormSchema } from '../types';
 
-export const usePersonAttributes = (patientUuid: string) => {
+export const usePersonAttributes = (patientUuid: string, formJson: FormSchema) => {
   const [personAttributes, setPersonAttributes] = useState<Array<PersonAttribute>>([]);
   const [isLoading, setIsLoading] = useState(true);
   const [error, setError] = useState(null);
 
   useEffect(() => {
-    if (patientUuid) {
+    if (formJson.meta?.personAttributes.hasPersonAttributeFields && patientUuid) {
       openmrsFetch(`${restBaseUrl}/patient/${patientUuid}?v=custom:(attributes)`)
         .then((response) => {
-          setPersonAttributes(response?.data?.attributes);
+          setPersonAttributes(response.data?.attributes);
           setIsLoading(false);
         })
         .catch((error) => {

src/processors/encounter/encounter-form-processor.ts

@@ -43,7 +43,10 @@ function useCustomHooks(context: Partial<FormProcessorContextProps>) {
     context.patient?.id,
     context.formJson,
   );
-  const { isLoading: isLoadingPersonAttributes, personAttributes } = usePersonAttributes(context.patient?.id);
+  const { isLoading: isLoadingPersonAttributes, personAttributes } = usePersonAttributes(
+    context.patient?.id,
+    context.formJson,
+  );
 
   useEffect(() => {
     setIsLoading(isLoadingPatientPrograms || isLoadingEncounter || isLoadingEncounterRole || isLoadingPersonAttributes);
@@ -170,9 +173,9 @@ export class EncounterFormProcessor extends FormProcessor {
 
     // save person attributes
     try {
-      const personattributes = preparePersonAttributes(context.formFields, context.location?.uuid);
-      const savedPrograms = await savePersonAttributes(context.patient, personattributes);
-      if (savedPrograms?.length) {
+      const personAttributes = preparePersonAttributes(context.formFields, context.location?.uuid);
+      const savedAttributes = await savePersonAttributes(context.patient, personAttributes);
+      if (savedAttributes?.length) {
         showSnackbar({
           title: translateFn('personAttributesSaved', 'Person attribute(s) saved successfully'),
           kind: 'success',
@@ -181,12 +184,12 @@ export class EncounterFormProcessor extends FormProcessor {
       }
     } catch (error) {
       const errorMessages = extractErrorMessagesFromResponse(error);
-      return Promise.reject({
+      throw {
         title: translateFn('errorSavingPersonAttributes', 'Error saving person attributes'),
         description: errorMessages.join(', '),
         kind: 'error',
         critical: true,
-      });
+      };
     }
 
     // save encounter

src/processors/encounter/encounter-processor-helper.ts

@@ -154,9 +154,7 @@ export function saveAttachments(fields: FormField[], encounter: OpenmrsEncounter
 }
 
 export function savePersonAttributes(patient: fhir.Patient, attributes: PersonAttribute[]) {
-  return attributes.map((personAttribute) => {
-    return savePersonAttribute(personAttribute, patient.id);
-  });
+  return attributes.map((personAttribute) => savePersonAttribute(personAttribute, patient.id));
 }
 
 export function getMutableSessionProps(context: FormContextProps) {

src/registry/inbuilt-components/control-templates.ts

@@ -50,12 +50,6 @@ export const controlTemplates: Array<ControlTemplate> = [
       },
     },
   },
-  {
-    name: 'person-attribute-location',
-    datasource: {
-      name: 'person_attribute_location_datasource',
-    },
-  },
 ];
 
 export const getControlTemplate = (name: string) => {

src/registry/inbuilt-components/inbuiltDataSources.ts

@@ -5,7 +5,6 @@ import { LocationDataSource } from '../../datasources/location-data-source';
 import { ProviderDataSource } from '../../datasources/provider-datasource';
 import { SelectConceptAnswersDatasource } from '../../datasources/select-concept-answers-datasource';
 import { EncounterRoleDataSource } from '../../datasources/encounter-role-datasource';
-import { PersonAttributeLocationDataSource } from '../../datasources/person-attribute-datasource';
 
 /**
  * @internal
@@ -36,8 +35,8 @@ export const inbuiltDataSources: Array<RegistryItem<DataSource<any>>> = [
     component: new EncounterRoleDataSource(),
   },
   {
-    name: 'person_attribute_location_datasource',
-    component: new PersonAttributeLocationDataSource(),
+    name: 'person-attribute-location',
+    component: new LocationDataSource(),
   },
 ];
 

src/registry/inbuilt-components/inbuiltTransformers.ts

@@ -1,3 +1,4 @@
+import { PersonAttributesTransformer } from '../../transformers/person-attributes-transformer';
 import { DefaultFormSchemaTransformer } from '../../transformers/default-schema-transformer';
 import { type FormSchemaTransformer } from '../../types';
 import { type RegistryItem } from '../registry';
@@ -7,4 +8,8 @@ export const inbuiltFormTransformers: Array<RegistryItem<FormSchemaTransformer>>
     name: 'DefaultFormSchemaTransformer',
     component: DefaultFormSchemaTransformer,
   },
+  {
+    name: 'PersonAttributesTransformer',
+    component: PersonAttributesTransformer,
+  },
 ];

src/registry/inbuilt-components/template-component-map.ts

@@ -25,8 +25,4 @@ export const templateToComponentMap = [
     name: 'encounter-role',
     baseControlComponent: UiSelectExtended,
   },
-  {
-    name: 'person_attribute_location_datasource',
-    baseControlComponent: UiSelectExtended,
-  },
 ];

src/registry/registry.ts

@@ -171,9 +171,10 @@ export async function getRegisteredFieldValueAdapter(type: string): Promise<Form
 }
 
 export async function getRegisteredFormSchemaTransformers(): Promise<FormSchemaTransformer[]> {
-  const transformers: FormSchemaTransformer[] = [];
+  const transformers: Array<FormSchemaTransformer> = [];
 
   const cachedTransformers = registryCache.formSchemaTransformers;
+
   if (Object.keys(cachedTransformers).length) {
     return Object.values(cachedTransformers);
   }