Skip to content

Commit b515e75

Browse files
authored
REPORT-909 Fix report renderer paths for editing report designs (#255)
1 parent 96f1fb6 commit b515e75

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

omod/src/main/java/org/openmrs/module/reporting/web/reports/renderers/DelimitedTextReportRendererFormController.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public DelimitedTextReportRendererFormController() { }
4747
/**
4848
* prepares a new form for the a DelimitedReportRenderer
4949
*/
50-
@RequestMapping("/module/reporting/reports/renderers/delimitedTextReportRenderer")
50+
@RequestMapping("/module/reporting/reports/renderers/delimitedTextReportRenderer.form")
5151
public void delimitedTextReportRenderer(ModelMap model,
5252
@RequestParam(required=false, value="reportDesignUuid") String reportDesignUuid,
5353
@RequestParam(required=false, value="reportDefinitionUuid") String reportDefinitionUuid,
@@ -95,7 +95,7 @@ else if (successUrl.startsWith(pathToRemove)) {
9595
* @throws IllegalAccessException
9696
* @throws InstantiationException
9797
*/
98-
@RequestMapping("/module/reporting/reports/renderers/saveDelimitedTextReportDesign")
98+
@RequestMapping("/module/reporting/reports/renderers/saveDelimitedTextReportDesign.form")
9999
public String saveDelimitedTextReportDesign(ModelMap model, HttpServletRequest request,
100100
@RequestParam(required=false, value="uuid") String uuid,
101101
@RequestParam(required=true, value="name") String name,

omod/src/main/java/org/openmrs/module/reporting/web/reports/renderers/ExcelReportRendererFormController.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public ExcelReportRendererFormController() { }
5757
/**
5858
* prepares a new form for the Excel report renderers
5959
*/
60-
@RequestMapping("/module/reporting/reports/renderers/excelReportRenderer")
60+
@RequestMapping("/module/reporting/reports/renderers/excelReportRenderer.form")
6161
public void excelReportRenderer(ModelMap model,
6262
@RequestParam(required=false, value="reportDesignUuid") String reportDesignUuid,
6363
@RequestParam(required=false, value="reportDefinitionUuid") String reportDefinitionUuid,
@@ -110,7 +110,7 @@ else if (successUrl.startsWith(pathToRemove)) {
110110
* @throws InstantiationException
111111
*/
112112
@SuppressWarnings("unchecked")
113-
@RequestMapping("/module/reporting/reports/renderers/saveExcelReportRenderer")
113+
@RequestMapping("/module/reporting/reports/renderers/saveExcelReportRenderer.form")
114114
public String saveExcelReportRenderer(ModelMap model, HttpServletRequest request,
115115
@RequestParam(required=false, value="uuid") String uuid,
116116
@RequestParam(required=true, value="name") String name,

omod/src/main/java/org/openmrs/module/reporting/web/reports/renderers/NonConfigurableReportRendererFormController.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public NonConfigurableReportRendererFormController() { }
4242
/**
4343
* prepares a new form for the a IndicatorReportRenderer
4444
*/
45-
@RequestMapping("/module/reporting/reports/renderers/nonConfigurableReportRenderer")
45+
@RequestMapping("/module/reporting/reports/renderers/nonConfigurableReportRenderer.form")
4646
public void nonConfigurableReportRenderer(ModelMap model,
4747
@RequestParam(required=false, value="reportDesignUuid") String reportDesignUuid,
4848
@RequestParam(required=false, value="reportDefinitionUuid") String reportDefinitionUuid,
@@ -78,7 +78,7 @@ else if (successUrl.startsWith(pathToRemove)) {
7878
/**
7979
* Saves report design
8080
*/
81-
@RequestMapping("/module/reporting/reports/renderers/saveNonConfigurableReportRenderer")
81+
@RequestMapping("/module/reporting/reports/renderers/saveNonConfigurableReportRenderer.form")
8282
public String saveNonConfigurableReportRenderer(ModelMap model, HttpServletRequest request,
8383
@RequestParam(required=false, value="uuid") String uuid,
8484
@RequestParam(required=true, value="name") String name,

omod/src/main/java/org/openmrs/module/reporting/web/reports/renderers/TextTemplateFormController.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public void initBinder(WebDataBinder binder) {
7979
* prepares a new form for the a TextTemplateRenderer
8080
* @throws UnsupportedEncodingException
8181
*/
82-
@RequestMapping("/module/reporting/reports/renderers/textTemplateReportRenderer")
82+
@RequestMapping("/module/reporting/reports/renderers/textTemplateReportRenderer.form")
8383
public void textTemplateReportRenderer(ModelMap model,
8484
@RequestParam(required=false, value="reportDesignUuid") String reportDesignUuid,
8585
@RequestParam(required=false, value="reportDefinitionUuid") String reportDefinitionUuid,
@@ -124,7 +124,7 @@ else if (successUrl.startsWith(pathToRemove)) {
124124
* Saves report design
125125
* @throws UnsupportedEncodingException
126126
*/
127-
@RequestMapping("/module/reporting/reports/renderers/saveTextTemplateReportRendererDesign")
127+
@RequestMapping("/module/reporting/reports/renderers/saveTextTemplateReportRendererDesign.form")
128128
public String saveTextTemplateReportRendererDesign(ModelMap model, HttpServletRequest request,
129129
@RequestParam(required=false, value="uuid") String uuid,
130130
@RequestParam(required=true, value="name") String name,
@@ -203,7 +203,7 @@ public UserParams userParams ( @RequestParam(required=false, value="userEnteredP
203203
return userParams;
204204
}
205205

206-
@RequestMapping( value="/module/reporting/reports/renderers/previewTextTemplateReportRenderer", method=RequestMethod.GET)
206+
@RequestMapping( value="/module/reporting/reports/renderers/previewTextTemplateReportRenderer.form", method=RequestMethod.GET)
207207
public void initPreviewForm(ModelMap model, HttpServletRequest request,
208208
@RequestParam(required=true, value="reportDefinition") String reportDefinitionUuid,
209209
@RequestParam(required=false, value="uuid") String uuid,
@@ -257,7 +257,7 @@ public void initPreviewForm(ModelMap model, HttpServletRequest request,
257257
}
258258

259259
@SuppressWarnings("unchecked")
260-
@RequestMapping(value="/module/reporting/reports/renderers/previewTextTemplateReportRenderer", method=RequestMethod.POST)
260+
@RequestMapping(value="/module/reporting/reports/renderers/previewTextTemplateReportRenderer.form", method=RequestMethod.POST)
261261
public void previewScript(ModelMap model, HttpServletRequest request,
262262
@RequestParam(required=true, value="reportDefinition") String reportDefinitionUuid,
263263
@RequestParam(required=true, value="uuid") String uuid,

0 commit comments

Comments
 (0)