Skip to content

Commit 22d4c66

Browse files
committed
MariaDB4j version update to 3.3.1 and remove ReusableDb
1 parent 908f59d commit 22d4c66

File tree

7 files changed

+6
-53
lines changed

7 files changed

+6
-53
lines changed

pom-step-01.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,6 @@
1717
</parent>
1818

1919
<dependencies>
20-
<dependency>
21-
<groupId>ch.vorburger.mariaDB4j</groupId>
22-
<artifactId>mariaDB4j-core</artifactId>
23-
<version>3.3.1</version>
24-
</dependency>
25-
2620
<dependency>
2721
<groupId>ch.vorburger.mariaDB4j</groupId>
2822
<artifactId>mariaDB4j</artifactId>

pom-step-02.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@
1717
</parent>
1818

1919
<dependencies>
20-
<dependency>
21-
<groupId>ch.vorburger.mariaDB4j</groupId>
22-
<artifactId>mariaDB4j-core</artifactId>
23-
<version>3.3.1</version>
24-
</dependency>
2520

2621
<dependency>
2722
<groupId>ch.vorburger.mariaDB4j</groupId>

pom-step-03.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@
1717
</parent>
1818

1919
<dependencies>
20-
<dependency>
21-
<groupId>ch.vorburger.mariaDB4j</groupId>
22-
<artifactId>mariaDB4j-core</artifactId>
23-
<version>3.3.1</version>
24-
</dependency>
2520

2621
<dependency>
2722
<groupId>ch.vorburger.mariaDB4j</groupId>

pom-step-04.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,6 @@
1717
</parent>
1818

1919
<dependencies>
20-
<dependency>
21-
<groupId>ch.vorburger.mariaDB4j</groupId>
22-
<artifactId>mariaDB4j-core</artifactId>
23-
<version>3.3.1</version>
24-
</dependency>
25-
2620
<dependency>
2721
<groupId>ch.vorburger.mariaDB4j</groupId>
2822
<artifactId>mariaDB4j</artifactId>

pom-step-05.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@
1717
</parent>
1818

1919
<dependencies>
20-
<dependency>
21-
<groupId>ch.vorburger.mariaDB4j</groupId>
22-
<artifactId>mariaDB4j-core</artifactId>
23-
<version>3.3.1</version>
24-
</dependency>
2520

2621
<dependency>
2722
<groupId>ch.vorburger.mariaDB4j</groupId>

pom.xml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -109,21 +109,6 @@
109109
</dependency>
110110
</dependencies>
111111

112-
<dependencyManagement>
113-
<dependencies>
114-
<dependency>
115-
<groupId>ch.vorburger.mariaDB4j</groupId>
116-
<artifactId>mariaDB4j-core</artifactId>
117-
<version>${mariadb4jVersion}</version>
118-
</dependency>
119-
<dependency>
120-
<groupId>ch.vorburger.mariaDB4j</groupId>
121-
<artifactId>mariaDB4j</artifactId>
122-
<version>${mariadb4jVersion}</version>
123-
</dependency>
124-
</dependencies>
125-
</dependencyManagement>
126-
127112

128113
<build>
129114
<finalName>openmrs-standalone-${openmrs.version}</finalName>

src/main/java/org/openmrs/standalone/MariaDbController.java

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -75,23 +75,18 @@ public static void startMariaDB(int port, String userPassword) throws Exception
7575
mariaDBConfig.addArg("--character-set-server=utf8");
7676

7777
DBConfiguration config = mariaDBConfig.build();
78+
mariaDB = DB.newEmbeddedDB(config);
79+
mariaDB.start();
7880

7981
if (isWindows) {
80-
// Check the dataDir variable that was defined above on line 66
81-
mariaDB = DB.newEmbeddedDB(config);
82-
mariaDB.start();
83-
84-
Connection conn = DriverManager.getConnection("jdbc:mariadb://localhost:" + port + "/", ROOT_USER, ROOT_PASSWORD);
85-
try (Statement stmt = conn.createStatement()) {
82+
// Windows-specific setup using JDBC try-with-resources
83+
try (Connection conn = DriverManager.getConnection("jdbc:mariadb://localhost:" + port + "/", ROOT_USER, ROOT_PASSWORD);
84+
Statement stmt = conn.createStatement()) {
8685
stmt.execute("ALTER USER 'root'@'localhost' IDENTIFIED BY '" + ROOT_PASSWORD + "';");
8786
stmt.execute("GRANT ALL PRIVILEGES ON *.* TO 'root'@'localhost' WITH GRANT OPTION;");
8887
}
89-
9088
} else {
91-
// For Linux and macOS
92-
mariaDB = DB.newEmbeddedDB(config);
93-
mariaDB.start();
94-
89+
// Linux and macOS-specific setup
9590
mariaDB.run("ALTER USER 'root'@'localhost' IDENTIFIED BY '" + ROOT_PASSWORD + "';");
9691
mariaDB.run("GRANT ALL PRIVILEGES ON *.* TO 'root'@'localhost' WITH GRANT OPTION;");
9792
}

0 commit comments

Comments
 (0)