Fix deprecated API usage and update Java source/target to 17 (#99)

* Initial plan

* Initial plan

Co-authored-by: dkayiwa <1390773+dkayiwa@users.noreply.github.com>

* Fix deprecated API usage and update Java source/target to 17

Co-authored-by: dkayiwa <1390773+dkayiwa@users.noreply.github.com>

* Rename variable 'Application' to 'applicationClass' for Java naming conventions

Co-authored-by: dkayiwa <1390773+dkayiwa@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: dkayiwa <1390773+dkayiwa@users.noreply.github.com>

Author: Copilot

.gitignore

@@ -1,5 +1,8 @@
 # maven ignores
 target/
+
+# Compiled class files
+*.class
 # IntelliJ ignores
 *.iml
 *.ipr

pom.xml

@@ -21,8 +21,8 @@
 
   <properties>
 
-      <maven.compiler.source>1.8</maven.compiler.source>
-      <maven.compiler.target>1.8</maven.compiler.target>
+      <maven.compiler.source>17</maven.compiler.source>
+      <maven.compiler.target>17</maven.compiler.target>
 
 
     <ciel.dictionary.openmrs.version>2.5.5</ciel.dictionary.openmrs.version>
@@ -153,8 +153,8 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <configuration>
           <fork>true</fork>
-          <source>1.8</source>
-          <target>1.8</target>
+          <source>17</source>
+          <target>17</target>
         </configuration>
       </plugin>
     </plugins>

src/main/java/org/openmrs/standalone/DbInitializer.java

@@ -20,7 +20,7 @@
 public class DbInitializer {
     // This is to be called via pom-step-04 with id 'import-demo-sql'
     public static void main(String[] args) throws Exception {
-        Class.forName("org.mariadb.jdbc.Driver").newInstance();
+        Class.forName("org.mariadb.jdbc.Driver").getDeclaredConstructor().newInstance();
 
         String sqlFilePath = args[0];
         String jdbcUrl = args[1];

src/main/java/org/openmrs/standalone/MainFrame.java

@@ -67,6 +67,8 @@
  */
 public class MainFrame extends javax.swing.JFrame implements ActionListener, UserInterface {
 
+	private static final long serialVersionUID = 1L;
+	
 	private ApplicationController appController;
 
 	private int tomcatPort = UserInterface.DEFAULT_TOMCAT_PORT;
@@ -118,7 +120,7 @@ public void windowClosing(java.awt.event.WindowEvent evt) {
 
 		setStatus(UserInterface.STATUS_MESSAGE_STARTING);
 
-		int preferredMetaKey = Toolkit.getDefaultToolkit().getMenuShortcutKeyMask();
+		int preferredMetaKey = Toolkit.getDefaultToolkit().getMenuShortcutKeyMaskEx();
 
 		fileMenu.setText("File");
 		browserMenuItem.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_B, preferredMetaKey));
@@ -298,14 +300,13 @@ public void actionPerformed(java.awt.event.ActionEvent evt) {
 
 		try{
 			if (System.getProperty("os.name").startsWith("Mac OS X")) {
-				Class noparams[] = {}; //no paramater
-				Class[] paramImage = new Class[1]; //Image parameter
+				Class<?>[] noparams = {};
+				Class<?>[] paramImage = new Class<?>[1];
 				paramImage[0] = Image.class;
-				Class Application = Class.forName("com.apple.eawt.Application");
-				Object application = Application.newInstance();
-				Method getApplication = Application.getDeclaredMethod("getApplication", noparams);
-				application = getApplication.invoke(null, null);
-				Method setDockIconImage = Application.getDeclaredMethod("setDockIconImage", paramImage);
+				Class<?> applicationClass = Class.forName("com.apple.eawt.Application");
+				Method getApplication = applicationClass.getDeclaredMethod("getApplication", noparams);
+				Object application = getApplication.invoke(null, (Object[]) null);
+				Method setDockIconImage = applicationClass.getDeclaredMethod("setDockIconImage", paramImage);
 				ImageIcon image = new ImageIcon(getClass().getResource("openmrs_logo_white.gif"));
 				setDockIconImage.invoke(application, image.getImage());
 			}

src/main/java/org/openmrs/standalone/StandaloneUtil.java

@@ -316,7 +316,7 @@ public static String getContextName() {
 
 	private static boolean setMysqlPassword(String url, String mysqlPort, String username, String newPassword) throws Exception {
 		try {
-			Class.forName("org.mariadb.jdbc.Driver").newInstance();
+			Class.forName("org.mariadb.jdbc.Driver").getDeclaredConstructor().newInstance();
 
 			MariaDbController.startMariaDB(mysqlPort, properties.getProperty("connection.password", ""));
 

src/main/java/org/openmrs/standalone/TomcatManager.java

@@ -20,7 +20,6 @@
 import java.net.MalformedURLException;
 import java.net.ServerSocket;
 import java.net.Socket;
-import java.security.AccessControlException;
 import java.util.Random;
 
 import ch.vorburger.exec.ManagedProcessException;
@@ -153,7 +152,7 @@ public void await() {
 				socket.setSoTimeout(10 * 1000); // Ten seconds
 				stream = socket.getInputStream();
 			}
-			catch (AccessControlException ace) {
+			catch (SecurityException ace) {
 				System.out.println("TomcatManager.accept security exception: " + ace.getMessage());
 				continue;
 			}