Skip to content

Commit 7c0600e

Browse files
committed
Use proper tool to look up OSGi service
Change-Id: I50f2d1da5836feb5b3b50ffb694f2d996e796929
1 parent 9011042 commit 7c0600e

File tree

6 files changed

+14
-10
lines changed

6 files changed

+14
-10
lines changed

mef-nrp-api/src/main/java/org/onosproject/mefnrpapi/api/impl/ForwardingConstructApiServiceImpl.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package org.onosproject.mefnrpapi.api.impl;
22

3-
import org.onosproject.cli.AbstractShellCommand;
43
import org.onosproject.ecord.carrierethernet.api.CarrierEthernetService;
54
import org.onosproject.ecord.carrierethernet.app.CarrierEthernetForwardingConstruct;
65
import org.onosproject.mefnrpapi.api.ApiResponseMessage;
@@ -14,12 +13,15 @@
1413
import javax.ws.rs.core.SecurityContext;
1514
import javax.ws.rs.core.UriBuilder;
1615
import javax.ws.rs.core.UriInfo;
16+
17+
import static org.onlab.osgi.DefaultServiceDirectory.getService;
18+
1719
import java.util.LinkedList;
1820
import java.util.List;
1921

2022
public class ForwardingConstructApiServiceImpl extends ForwardingConstructApiService {
2123

22-
CarrierEthernetService ceManager = AbstractShellCommand.get(CarrierEthernetService.class);
24+
CarrierEthernetService ceManager = getService(CarrierEthernetService.class);
2325

2426
private static final String CHECK_LOG = " Check ONOS log for details.";
2527
private static final String NOT_TRANSLATED = "Could not translate FC.";

mef-nrp-api/src/main/java/org/onosproject/mefnrpapi/api/impl/LogicalTerminationPointApiServiceImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.onosproject.mefnrpapi.api.impl;
22

3-
import org.onosproject.cli.AbstractShellCommand;
3+
import org.onlab.osgi.DefaultServiceDirectory;
44
import org.onosproject.ecord.carrierethernet.api.CarrierEthernetService;
55
import org.onosproject.ecord.carrierethernet.app.CarrierEthernetLogicalTerminationPoint;
66
import org.onosproject.mefnrpapi.api.ApiResponseMessage;
@@ -22,7 +22,7 @@
2222
public class LogicalTerminationPointApiServiceImpl extends LogicalTerminationPointApiService {
2323

2424
CarrierEthernetService ceManager =
25-
AbstractShellCommand.get(CarrierEthernetService.class);
25+
DefaultServiceDirectory.getService(CarrierEthernetService.class);
2626

2727
private static final String NOT_TRANSLATED = "Could not translate LTP.";
2828
private static final String EXISTS = "LTP already exists.";

mef-sca-api/src/main/java/org/onosproject/mefscaapi/ApiDocRegistrator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,4 @@ public ApiDocRegistrator() {
3030
"MEF SCA REST API",
3131
ApiDocRegistrator.class.getClassLoader()));
3232
}
33-
}
33+
}

mef-sca-api/src/main/java/org/onosproject/mefscaapi/api/impl/ScaEthFdFrEcApiServiceImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package org.onosproject.mefscaapi.api.impl;
22

3-
import org.onosproject.cli.AbstractShellCommand;
43
import org.onosproject.ecord.carrierethernet.api.CarrierEthernetService;
54
import org.onosproject.ecord.carrierethernet.app.CarrierEthernetVirtualConnection;
65
import org.onosproject.mefscaapi.api.ApiResponseMessage;
@@ -16,11 +15,12 @@
1615
import java.util.LinkedList;
1716
import java.util.List;
1817

18+
import static org.onlab.osgi.DefaultServiceDirectory.getService;
1919
import static org.slf4j.LoggerFactory.getLogger;
2020

2121
public class ScaEthFdFrEcApiServiceImpl extends SCAETHFDFrECApiService {
2222

23-
CarrierEthernetService ceManager = AbstractShellCommand.get(CarrierEthernetService.class);
23+
CarrierEthernetService ceManager = getService(CarrierEthernetService.class);
2424

2525
private static final Logger log = getLogger(ScaEthFdFrEcApiServiceImpl.class);
2626

mef-sca-api/src/main/java/org/onosproject/mefscaapi/api/impl/ScaEthFppUniNApiServiceImpl.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package org.onosproject.mefscaapi.api.impl;
22

3-
import org.onosproject.cli.AbstractShellCommand;
43
import org.onosproject.ecord.carrierethernet.api.CarrierEthernetService;
54
import org.onosproject.ecord.carrierethernet.app.CarrierEthernetUni;
65
import org.onosproject.mefscaapi.api.ApiResponseMessage;
@@ -13,12 +12,15 @@
1312
import javax.ws.rs.core.Response;
1413
import javax.ws.rs.core.SecurityContext;
1514
import javax.ws.rs.core.UriBuilder;
15+
16+
import static org.onlab.osgi.DefaultServiceDirectory.getService;
17+
1618
import java.util.LinkedList;
1719
import java.util.List;
1820

1921
public class ScaEthFppUniNApiServiceImpl extends SCAETHFPPUNINApiService {
2022

21-
CarrierEthernetService ceManager = AbstractShellCommand.get(CarrierEthernetService.class);
23+
CarrierEthernetService ceManager = getService(CarrierEthernetService.class);
2224

2325
private static final String NOT_TRANSLATED = "Could not translate UNI.";
2426
private static final String EXISTS = "UNI already exists.";

mef-sca-api/src/main/java/org/onosproject/mefscaapi/api/impl/package-info.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@
1616
/**
1717
* MEF SCA API implementations.
1818
*/
19-
package org.onosproject.mefscaapi.api.impl;
19+
package org.onosproject.mefscaapi.api.impl;

0 commit comments

Comments
 (0)