Fix: Add proper check to avoid IndexOutOfBoundsException.

Niraj Dubey · Charles Chan · commit 2d20f33dca66 · 2019-09-27T19:41:40.000Z
Change-Id: I50e2eedd53dcc81aa51a8ce6dd5dcf13ab967652
diff --git a/drivers/ovsdb/src/main/java/org/onosproject/drivers/ovsdb/OvsdbQosConfig.java b/drivers/ovsdb/src/main/java/org/onosproject/drivers/ovsdb/OvsdbQosConfig.java
@@ -136,7 +136,7 @@ public void deleteQueues(QosId qosId, List<Long> queueKeys) {
     // is used in the core. So DeviceId need be changed to OvsdbNodeId.
     private OvsdbNodeId changeDeviceIdToNodeId(DeviceId deviceId) {
         String[] splits = deviceId.toString().split(":");
-        if (splits.length < 1) {
+        if (splits.length < 2) {
             return null;
         }
         IpAddress ipAddress = IpAddress.valueOf(splits[1]);

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ public void deleteQueues(QosId qosId, List<Long> queueKeys) {`
`136`	`136`	`// is used in the core. So DeviceId need be changed to OvsdbNodeId.`
`137`	`137`	`private OvsdbNodeId changeDeviceIdToNodeId(DeviceId deviceId) {`
`138`	`138`	`String[] splits = deviceId.toString().split(":");`
`139`		`- if (splits.length < 1) {`
	`139`	`+ if (splits.length < 2) {`
`140`	`140`	`return null;`
`141`	`141`	`}`
`142`	`142`	`IpAddress ipAddress = IpAddress.valueOf(splits[1]);`