Skip to content

Commit 0d1d790

Browse files
committed
fixup: restore support for Node18
1 parent 49f24c7 commit 0d1d790

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

.github/actions/pnpm-setup/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ runs:
66
steps:
77
# Install nodejs. https://github.com/actions/setup-node
88
- name: Setup Node.js
9-
uses: actions/setup-node@v5
9+
uses: actions/setup-node@v4
1010
with:
11-
node-version: 20.x
11+
node-version: 18.x
1212

1313
# Install pnpm. https://github.com/pnpm/action-setup
1414
- uses: pnpm/action-setup@v4

.github/workflows/e2e.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,11 @@ jobs:
9090
with:
9191
version: 9
9292

93-
- name: Set up NodeJS v20
94-
uses: actions/setup-node@v5
93+
- name: Set up NodeJS v18
94+
uses: actions/setup-node@v4
9595
with:
9696
cache: pnpm # cache pnpm store
97-
node-version: 20.19.5
97+
node-version: 18.18.2
9898

9999
- name: Install packages
100100
run: pnpm install

.github/workflows/pre-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
uses: actions/checkout@v4
2121

2222
# Setup .npmrc file to publish to npm
23-
- uses: actions/setup-node@v5
23+
- uses: actions/setup-node@v4
2424
with:
2525
registry-url: "https://registry.npmjs.org"
2626

.github/workflows/v2-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
uses: actions/checkout@v4
1313

1414
# Setup .npmrc file to publish to npm
15-
- uses: actions/setup-node@v5
15+
- uses: actions/setup-node@v4
1616
with:
1717
registry-url: "https://registry.npmjs.org"
1818

packages/open-next/src/core/routing/util.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -105,14 +105,14 @@ export function convertRes(res: OpenNextNodeResponse): InternalResult {
105105
const isBase64Encoded =
106106
isBinaryContentType(headers["content-type"]) ||
107107
!!headers["content-encoding"];
108-
const body =
109-
res._chunks == null
110-
? new ReadableStream({
111-
start(controller) {
112-
controller.close();
113-
},
114-
})
115-
: ReadableStream.from(res._chunks);
108+
const body = new ReadableStream({
109+
start(controller) {
110+
for (const chunk of res._chunks ?? []) {
111+
controller.enqueue(chunk);
112+
}
113+
controller.close();
114+
},
115+
});
116116
return {
117117
type: "core",
118118
statusCode,

0 commit comments

Comments
 (0)