review fix

Author: conico974

packages/open-next/src/overrides/imageLoader/fs-dev.ts

@@ -1,15 +1,14 @@
-import fs from "node:fs/promises";
-import { Readable } from "node:stream";
+import fs from "node:fs";
 import type { ImageLoader } from "types/overrides";
 
 export default {
   name: "fs-dev",
   load: async (url: string) => {
     const basePath = "../../assets";
-    const fileData = await fs.readFile(`${basePath}/${url}`);
+    const body = fs.createReadStream(`${basePath}/${url}`);
     const contentType = url.endsWith(".png") ? "image/png" : "image/jpeg";
     return {
-      body: Readable.from(fileData),
+      body,
       contentType,
       cacheControl: "public, max-age=31536000, immutable",
     };

packages/open-next/src/overrides/incrementalCache/fs-dev.ts

@@ -23,7 +23,10 @@ const cache: IncrementalCache = {
   },
   set: async (key, value, isFetch) => {
     const data = JSON.stringify(value);
-    await fs.writeFile(getCacheKey(key), data);
+    const cacheKey = getCacheKey(key);
+    // We need to create the directory before writing the file
+    await fs.mkdir(path.dirname(cacheKey), { recursive: true });
+    await fs.writeFile(cacheKey, data);
   },
   delete: async (key) => {
     await fs.rm(getCacheKey(key));

packages/open-next/src/overrides/tagCache/fs-dev.ts

@@ -33,12 +33,13 @@ const tagCache: TagCache = {
     return revalidatedTags.length > 0 ? -1 : (lastModified ?? Date.now());
   },
   writeTags: async (newTags) => {
-    const unchangedTags = tags.filter((tagPathMapping) =>
-      newTags.some(
-        (tag) =>
-          tag.tag === tagPathMapping.tag.S &&
-          tag.path === tagPathMapping.path.S,
-      ),
+    const unchangedTags = tags.filter(
+      (tagPathMapping) =>
+        !newTags.some(
+          (tag) =>
+            tag.tag === tagPathMapping.tag.S &&
+            tag.path === tagPathMapping.path.S,
+        ),
     );
     tags = unchangedTags.concat(
       newTags.map((tag) => ({

packages/open-next/src/overrides/wrappers/express-dev.ts

@@ -1,5 +1,3 @@
-// dev/wrapper.ts
-// You'll need to install express
 import express from "express";
 
 import type { StreamCreator } from "types/open-next.js";
@@ -20,7 +18,6 @@ const wrapper: WrapperHandler = async (handler, converter) => {
         res.writeHead(prelude.statusCode, prelude.headers);
         return res;
       },
-      onFinish: () => {},
     };
     await imageHandler(internalEvent, _res);
   });