perf(OpenNextResponse): do not store the chunks for streamed responses

Author: vicb

.changeset/honest-lamps-smell.md

@@ -0,0 +1,10 @@
+---
+"@opennextjs/aws": minor
+---
+
+perf(OpenNextResponse): do not store the chunks for streamed responses
+
+There is no need to store the chunks for streamed responses.
+Not storing the chunks allows saving memory.
+
+Note that `OpenNextHandler` will now return an empty body for streamed responses.

packages/open-next/src/http/openNextResponse.ts

@@ -283,7 +283,10 @@ export class OpenNextNodeResponse extends Transform implements ServerResponse {
   }
 
   private _internalWrite(chunk: any, encoding: BufferEncoding) {
-    this._chunks.push(Buffer.from(chunk, encoding));
+    if (!this.streamCreator) {
+      // Do not keep chunks around for streamed responses
+      this._chunks.push(Buffer.from(chunk, encoding));
+    }
     this.push(chunk, encoding);
     this.streamCreator?.onWrite?.();
   }
@@ -306,7 +309,7 @@ export class OpenNextNodeResponse extends Transform implements ServerResponse {
       this.flushHeaders();
     }
     // In some cases we might not have a store i.e. for example in the image optimization function
-    // We may want to reconsider this in the future, it might be intersting to have access to this store everywhere
+    // We may want to reconsider this in the future, it might be interesting to have access to this store everywhere
     globalThis.__openNextAls
       ?.getStore()
       ?.pendingPromiseRunner.add(this.onEnd(this.headers));