refactor resolves plugin

Author: conico974

packages/open-next/src/plugins/resolve.ts

@@ -31,15 +31,39 @@ export interface IPluginSettings {
   fnName?: string;
 }
 
-function getOverrideOrDefault<
-  Override extends string | LazyLoadedOverride<any>,
->(override: Override, defaultOverride: string) {
+function getOverrideOrDummy<Override extends string | LazyLoadedOverride<any>>(
+  override: Override,
+) {
   if (typeof override === "string") {
     return override;
   }
-  return defaultOverride;
+  // We can return dummy here because if it's not a string, it's a LazyLoadedOverride
+  return "dummy";
 }
 
+// This could be useful in the future to map overrides to nested folders
+const nameToFolder = {
+  wrapper: "wrappers",
+  converter: "converters",
+  tagCache: "tagCache",
+  queue: "queue",
+  incrementalCache: "incrementalCache",
+  imageLoader: "imageLoader",
+  originResolver: "originResolver",
+  warmer: "warmer",
+};
+
+const defaultOverrides = {
+  wrapper: "aws-lambda",
+  converter: "aws-apigw-v2",
+  tagCache: "dynamodb",
+  queue: "sqs",
+  incrementalCache: "s3",
+  imageLoader: "s3",
+  originResolver: "pattern-env",
+  warmer: "aws-lambda",
+};
+
 /**
  * @param opts.overrides - The name of the overrides to use
  * @returns
@@ -54,77 +78,18 @@ export function openNextResolvePlugin({
       logger.debug(`OpenNext Resolve plugin for ${fnName}`);
       build.onLoad({ filter: /core(\/|\\)resolve\.js/g }, async (args) => {
         let contents = readFileSync(args.path, "utf-8");
-        //TODO: refactor this. Every override should be at the same place so we can generate this dynamically
-        if (overrides?.wrapper) {
-          contents = contents.replace(
-            "../overrides/wrappers/aws-lambda.js",
-            `../overrides/wrappers/${getOverrideOrDefault(
-              overrides.wrapper,
-              "aws-lambda",
-            )}.js`,
-          );
-        }
-        if (overrides?.converter) {
-          contents = contents.replace(
-            "../overrides/converters/aws-apigw-v2.js",
-            `../overrides/converters/${getOverrideOrDefault(
-              overrides.converter,
-              "dummy",
-            )}.js`,
-          );
-        }
-        if (overrides?.tagCache) {
-          contents = contents.replace(
-            "../overrides/tagCache/dynamodb.js",
-            `../overrides/tagCache/${getOverrideOrDefault(
-              overrides.tagCache,
-              "dynamodb-lite",
-            )}.js`,
-          );
-        }
-        if (overrides?.queue) {
-          contents = contents.replace(
-            "../overrides/queue/sqs.js",
-            `../overrides/queue/${getOverrideOrDefault(
-              overrides.queue,
-              "sqs-lite",
-            )}.js`,
-          );
-        }
-        if (overrides?.incrementalCache) {
-          contents = contents.replace(
-            "../overrides/incrementalCache/s3.js",
-            `../overrides/incrementalCache/${getOverrideOrDefault(
-              overrides.incrementalCache,
-              "s3-lite",
-            )}.js`,
-          );
-        }
-        if (overrides?.imageLoader) {
-          contents = contents.replace(
-            "../overrides/imageLoader/s3.js",
-            `../overrides/imageLoader/${getOverrideOrDefault(
-              overrides.imageLoader,
-              "s3",
-            )}.js`,
-          );
-        }
-        if (overrides?.originResolver) {
-          contents = contents.replace(
-            "../overrides/originResolver/pattern-env.js",
-            `../overrides/originResolver/${getOverrideOrDefault(
-              overrides.originResolver,
-              "pattern-env",
-            )}.js`,
-          );
-        }
-        if (overrides?.warmer) {
+        const overridesEntries = Object.entries(overrides ?? {});
+        for (const [overrideName, overrideValue] of overridesEntries) {
+          if (!overrideValue) {
+            continue;
+          }
+          const folder =
+            nameToFolder[overrideName as keyof typeof nameToFolder];
+          const defaultOverride =
+            defaultOverrides[overrideName as keyof typeof defaultOverrides];
           contents = contents.replace(
-            "../overrides/warmer/aws-lambda.js",
-            `../overrides/warmer/${getOverrideOrDefault(
-              overrides.warmer,
-              "aws-lambda",
-            )}.js`,
+            `../overrides/${folder}/${defaultOverride}.js`,
+            `../overrides/${folder}/${getOverrideOrDummy(overrideValue)}.js`,
           );
         }
         return {