fix: return when an error is downplayed (#708)

* fix: return when an error is downplayed

* lint

* changeset

* review

Author: sommeeeer

.changeset/orange-impalas-repeat.md

@@ -0,0 +1,9 @@
+---
+"@opennextjs/aws": patch
+---
+
+fix: add early return for downplayed aws-sdk errors
+
+In the logger adapter:
+
+An issue was identified where downplayed errors from the aws-sdk client (f.ex NoSuchKey from S3) would not return from the function early. This caused unnecessary invocation of `console.error` outside the conditional.

packages/open-next/src/adapters/logger.ts

@@ -43,8 +43,9 @@ const isDownplayedErrorLog = (errorLog: AwsSdkClientCommandErrorLog) =>
 export function error(...args: any[]) {
   // we try to catch errors from the aws-sdk client and downplay some of them
   if (args.some((arg) => isDownplayedErrorLog(arg))) {
-    debug(...args);
-  } else if (args.some((arg) => isOpenNextError(arg))) {
+    return debug(...args);
+  }
+  if (args.some((arg) => isOpenNextError(arg))) {
     // In case of an internal error, we log it with the appropriate log level
     const error = args.find((arg) => isOpenNextError(arg))!;
     if (error.logLevel < getOpenNextErrorLogLevel()) {