Skip to content

Commit c737e11

Browse files
committed
review fix
1 parent 189a87e commit c737e11

File tree

3 files changed

+16
-18
lines changed

3 files changed

+16
-18
lines changed

packages/open-next/src/core/requestHandler.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,22 +31,22 @@ export async function openNextHandler(
3131
internalEvent: InternalEvent,
3232
responseStreaming?: StreamCreator,
3333
): Promise<InternalResult> {
34+
const initialHeaders = internalEvent.headers;
3435
// We run everything in the async local storage context so that it is available in the middleware as well as in NextServer
3536
return runWithOpenNextRequestContext(
36-
{ isISRRevalidation: internalEvent.headers["x-isr"] === "1" },
37+
{ isISRRevalidation: initialHeaders["x-isr"] === "1" },
3738
async () => {
38-
if (internalEvent.headers["x-forwarded-host"]) {
39-
internalEvent.headers.host = internalEvent.headers["x-forwarded-host"];
39+
if (initialHeaders["x-forwarded-host"]) {
40+
initialHeaders.host = initialHeaders["x-forwarded-host"];
4041
}
4142
debug("internalEvent", internalEvent);
4243

4344
// These 2 will get overwritten by the routing handler if not using an external middleware
4445
const internalHeaders = {
4546
initialPath:
46-
internalEvent.headers[INTERNAL_HEADER_INITIAL_PATH] ??
47-
internalEvent.rawPath,
48-
resolvedRoutes: internalEvent.headers[INTERNAL_HEADER_RESOLVED_ROUTES]
49-
? JSON.parse(internalEvent.headers[INTERNAL_HEADER_RESOLVED_ROUTES])
47+
initialHeaders[INTERNAL_HEADER_INITIAL_PATH] ?? internalEvent.rawPath,
48+
resolvedRoutes: initialHeaders[INTERNAL_HEADER_RESOLVED_ROUTES]
49+
? JSON.parse(initialHeaders[INTERNAL_HEADER_RESOLVED_ROUTES])
5050
: ([] as ResolvedRoute[]),
5151
};
5252

packages/open-next/src/core/routing/routeMatcher.ts

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,14 @@ export const apiPrefix = RoutesManifest.basePath
1818
: "/api";
1919

2020
function routeMatcher(routeDefinitions: RouteDefinition[]) {
21-
const regexp = routeDefinitions.map((route) => {
22-
return {
23-
page: route.page,
24-
regexp: new RegExp(
25-
route.regex
26-
.replace("^/", optionalLocalePrefixRegex)
27-
.replace("^/", optionalBasepathPrefixRegex),
28-
),
29-
};
30-
});
21+
const regexp = routeDefinitions.map((route) => ({
22+
page: route.page,
23+
regexp: new RegExp(
24+
route.regex
25+
.replace("^/", optionalLocalePrefixRegex)
26+
.replace("^/", optionalBasepathPrefixRegex),
27+
),
28+
}));
3129

3230
// We need to use AppPathRoutesManifest here
3331
const appPathsSet = new Set(

packages/open-next/src/core/routingHandler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ import {
2828
} from "./routing/routeMatcher";
2929

3030
export const MIDDLEWARE_HEADER_PREFIX = "x-middleware-response-";
31+
export const MIDDLEWARE_HEADER_PREFIX_LEN = MIDDLEWARE_HEADER_PREFIX.length;
3132
export const INTERNAL_HEADER_PREFIX = "x-opennext-";
3233
export const INTERNAL_HEADER_INITIAL_PATH = `${INTERNAL_HEADER_PREFIX}initial-path`;
3334
export const INTERNAL_HEADER_RESOLVED_ROUTES = `${INTERNAL_HEADER_PREFIX}resolved-routes`;
34-
export const MIDDLEWARE_HEADER_PREFIX_LEN = MIDDLEWARE_HEADER_PREFIX.length;
3535

3636
// Geolocation headers starting from Nextjs 15
3737
// See https://github.com/vercel/vercel/blob/7714b1c/packages/functions/src/headers.ts

0 commit comments

Comments
 (0)