Skip to content

[perf] Do not query the tag cache again when the cache interceptor is enabled and the page has been revalidated #987

@vicb

Description

@vicb

An example on this log:

# The cache interceptor figures out that the page has been revalidated
[R2IncrementalCache]  Get /tags
[KVNextModeTagCache]  getLastRevalidated, tags=_N_T_/layout,_N_T_/tags/layout,_N_T_/tags/page,_N_T_/tags,tag1,tag2, time=1758888624869
[KVNextModeTagCache]  hasBeenRevalidated, tags=_N_T_/layout,_N_T_/tags/layout,_N_T_/tags/page,_N_T_/tags,tag1,tag2, revalidated=true

# The main bundle will query the Tag Cache again
using custom cache handler Cache
[R2IncrementalCache]  Get /tags
[KVNextModeTagCache]  getLastRevalidated, tags=_N_T_/layout,_N_T_/tags/layout,_N_T_/tags/page,_N_T_/tags,tag1,tag2, time=1758888624869
[KVNextModeTagCache]  hasBeenRevalidated, tags=_N_T_/layout,_N_T_/tags/layout,_N_T_/tags/page,_N_T_/tags,tag1,tag2, revalidated=true
[R2IncrementalCache]  Get 23131daa06ac40900c83b08442164cc34a6e525e6987c29584733391f7f92c55
[KVNextModeTagCache]  getLastRevalidated, tags=tag1,_N_T_/layout,_N_T_/tags/layout,_N_T_/tags/page,_N_T_/tags, time=1758888168131
[KVNextModeTagCache]  hasBeenRevalidated, tags=tag1,_N_T_/layout,_N_T_/tags/layout,_N_T_/tags/page,_N_T_/tags, revalidated=false
[R2IncrementalCache]  Get 4269022e71d406e52c025fa88e006f3aede23248acb4b5f271f311f7e5c23df0
[KVNextModeTagCache]  getLastRevalidated, tags=tag2,_N_T_/layout,_N_T_/tags/layout,_N_T_/tags/page,_N_T_/tags, time=1758888624869
[KVNextModeTagCache]  hasBeenRevalidated, tags=tag2,_N_T_/layout,_N_T_/tags/layout,_N_T_/tags/page,_N_T_/tags, revalidated=true
[R2IncrementalCache]  Set 4269022e71d406e52c025fa88e006f3aede23248acb4b5f271f311f7e5c23df0
[R2IncrementalCache]  Set /tags

This is a small perf optimization that would only speed up revalidations.
So not high priority but rather a nice to have

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions