Skip to content

Commit 0bd6a2a

Browse files
committed
fixup! feedback comment
1 parent f5fe6d3 commit 0bd6a2a

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

packages/cloudflare/src/api/kvCache.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@ class Cache implements IncrementalCache {
5454
const response = await this.assets.fetch(url);
5555
this.debug(`- From Assets`);
5656
if (response.ok) {
57+
// TODO: consider populating KV with the asset value if faster.
58+
// This could be optional as KV writes are $$.
59+
// See https://github.com/opennextjs/opennextjs-cloudflare/pull/194#discussion_r1893166026
5760
entry = {
5861
value: await response.json(),
5962
// __BUILD_TIMESTAMP_MS__ is injected by ESBuild.

0 commit comments

Comments
 (0)