feat: cli arg to disable minification

Author: james-elicx

.changeset/nine-impalas-wave.md

@@ -0,0 +1,7 @@
+---
+"@opennextjs/cloudflare": minor
+---
+
+feat: cli arg to disable minification
+
+The cache handler currently forces minification. There is now a CLI arg to disable minification for the build. At the moment, this only applies to the cache handler but may be used for other parts of the build in the future when minification is introduced to them.

packages/cloudflare/src/cli/args.ts

@@ -5,9 +5,10 @@ import { resolve } from "node:path";
 export function getArgs(): {
   skipBuild: boolean;
   outputDir?: string;
+  disableMinification?: boolean;
 } {
   const {
-    values: { skipBuild, output },
+    values: { skipBuild, output, disableMinification },
   } = parseArgs({
     options: {
       skipBuild: {
@@ -19,6 +20,9 @@ export function getArgs(): {
         type: "string",
         short: "o",
       },
+      disableMinification: {
+        type: "boolean",
+      },
     },
     allowPositionals: false,
   });
@@ -32,6 +36,7 @@ export function getArgs(): {
   return {
     outputDir,
     skipBuild: skipBuild || ["1", "true", "yes"].includes(String(process.env.SKIP_NEXT_APP_BUILD)),
+    disableMinification,
   };
 }
 

packages/cloudflare/src/cli/build/patches/investigated/patch-cache.ts

@@ -18,7 +18,7 @@ export async function patchCache(code: string, config: Config): Promise<string>
     outfile: cacheHandlerOutputFile,
     format: "esm",
     target: "esnext",
-    minify: true,
+    minify: config.build.shouldMinify,
     define: {
       "process.env.__OPENNEXT_KV_BINDING_NAME": `"${config.cache.kvBindingName}"`,
     },

packages/cloudflare/src/cli/config.ts

@@ -16,6 +16,8 @@ export type Config = {
     timestamp: number;
     // Whether to skip building the Next.js app or not
     skipNextBuild: boolean;
+    // Whether minification should be enabled or not
+    shouldMinify: boolean;
   };
 
   paths: {
@@ -69,6 +71,7 @@ export function getConfig(projectOpts: ProjectOptions): Config {
     build: {
       timestamp: Date.now(),
       skipNextBuild: !!projectOpts.skipBuild,
+      shouldMinify: !projectOpts.disableMinification,
     },
 
     paths: {
@@ -106,6 +109,8 @@ export type ProjectOptions = {
   outputDir: string;
   // Whether the Next.js build should be skipped (i.e. if the `.next` dir is already built)
   skipBuild?: boolean;
+  // Whether minification of the worker should be disabled
+  disableMinification?: boolean;
 };
 
 /**

packages/cloudflare/src/cli/index.ts

@@ -13,10 +13,11 @@ if (!["js", "cjs", "mjs", "ts"].some((ext) => existsSync(`./next.config.${ext}`)
   throw new Error("Error: Not in a Next.js app project");
 }
 
-const { skipBuild, outputDir } = getArgs();
+const { skipBuild, outputDir, disableMinification } = getArgs();
 
 await build({
   sourceDir: nextAppDir,
   outputDir: resolve(outputDir ?? nextAppDir, ".worker-next"),
   skipBuild,
+  disableMinification,
 });