Skip to content

Commit 316425a

Browse files
fix e2e tests on CI
We had different versions of playwright for installing the browsers than for running the tests, so it could not find them. Moved the installation to a pre- step, since when the browsers are already installed this command is very fast.
1 parent e795a1e commit 316425a

File tree

3 files changed

+20
-21
lines changed

3 files changed

+20
-21
lines changed

.github/workflows/playwright.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ jobs:
1515
node-version: lts/*
1616
- name: Install dependencies
1717
run: npm install -g pnpm && pnpm install
18-
- name: Install Playwright Browsers
19-
run: pnpm dlx playwright install --with-deps
2018
- name: Run Playwright tests
2119
run: pnpm e2e
2220
- uses: actions/upload-artifact@v4

next/api/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,17 @@
1010
"build:worker": "builder",
1111
"dev:worker": "wrangler dev --port 8770",
1212
"preview:worker": "pnpm build:worker && pnpm dev:worker",
13+
"pree2e": "playwright install --with-deps",
1314
"e2e": "playwright test"
1415
},
1516
"dependencies": {
16-
"next": "14.2.5",
1717
"builder": "workspace:*",
18+
"next": "14.2.5",
1819
"react": "^18",
1920
"react-dom": "^18"
2021
},
2122
"devDependencies": {
22-
"@playwright/test": "^1.46.1",
23+
"@playwright/test": "1.47.0",
2324
"@types/node": "^22.2.0",
2425
"node-url": "npm:url@^0.11.4",
2526
"wrangler": "3.77.0"

pnpm-lock.yaml

Lines changed: 17 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)