refactor: CI detection for Playwright (#588)

Author: vicb

examples/bugs/gh-119/e2e/playwright.config.ts

@@ -1,3 +1,3 @@
 import { configurePlaywright } from "../../../common/config-e2e";
 
-export default configurePlaywright("gh-119", { isCI: !!process.env.CI });
+export default configurePlaywright("gh-119");

examples/bugs/gh-219/e2e/playwright.config.ts

@@ -1,3 +1,3 @@
 import { configurePlaywright } from "../../../common/config-e2e";
 
-export default configurePlaywright("gh-219", { isCI: !!process.env.CI });
+export default configurePlaywright("gh-219");

examples/bugs/gh-223/e2e/playwright.config.ts

@@ -1,3 +1,3 @@
 import { configurePlaywright } from "../../../common/config-e2e";
 
-export default configurePlaywright("gh-223", { isCI: !!process.env.CI });
+export default configurePlaywright("gh-223");

examples/common/config-e2e.ts

@@ -8,7 +8,7 @@ export function configurePlaywright(
   app: AppName,
   {
     // Do we run on CI?
-    isCI = false,
+    isCI = Boolean(process.env.CI),
     // Do we run on workers (`wrangler dev`) or on Node (`next dev`)
     isWorker = true,
     // Tests with multiple browsers

examples/create-next-app/e2e/playwright.config.ts

@@ -1,3 +1,3 @@
 import { configurePlaywright } from "../../common/config-e2e";
 
-export default configurePlaywright("create-next-app", { isCI: !!process.env.CI, multipleBrowsers: true });
+export default configurePlaywright("create-next-app", { multipleBrowsers: true });

examples/e2e/app-pages-router/e2e/playwright.config.ts

@@ -1,3 +1,3 @@
 import { configurePlaywright } from "../../../common/config-e2e";
 
-export default configurePlaywright("app-pages-router", { isCI: !!process.env.CI });
+export default configurePlaywright("app-pages-router");

examples/e2e/app-router/e2e/playwright.config.ts

@@ -1,3 +1,3 @@
 import { configurePlaywright } from "../../../common/config-e2e";
 
-export default configurePlaywright("app-router", { isCI: !!process.env.CI });
+export default configurePlaywright("app-router");

examples/e2e/pages-router/e2e/playwright.config.ts

@@ -1,3 +1,3 @@
 import { configurePlaywright } from "../../../common/config-e2e";
 
-export default configurePlaywright("pages-router", { isCI: !!process.env.CI });
+export default configurePlaywright("pages-router");

examples/middleware/e2e/playwright.config.ts

@@ -1,3 +1,3 @@
 import { configurePlaywright } from "../../common/config-e2e";
 
-export default configurePlaywright("middleware", { isCI: !!process.env.CI, multipleBrowsers: true });
+export default configurePlaywright("middleware", { multipleBrowsers: true });

examples/overrides/d1-tag-next/e2e/playwright.config.ts

@@ -1,4 +1,4 @@
 import { configurePlaywright } from "../../../common/config-e2e";
 
 // Here we don't want to run the tests in parallel
-export default configurePlaywright("d1-tag-next", { isCI: !!process.env.CI, parallel: false });
+export default configurePlaywright("d1-tag-next", { parallel: false });