comments

Author: james-elicx

.github/workflows/checks.yml

@@ -13,7 +13,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        script: [prettier, lint, ts-check, test]
+        script: [prettier:check, lint:check, ts:check, test]
     steps:
       - name: Check out code
         uses: actions/checkout@v4

package.json

@@ -8,13 +8,13 @@
     "prettier": "3.3.3"
   },
   "scripts": {
-    "prettier": "prettier --check .",
+    "prettier:check": "prettier --check .",
     "prettier:fix": "prettier --write .",
-    "lint": "pnpm -r lint:check",
+    "lint:check": "pnpm -r lint:check",
     "lint:fix": "pnpm -r lint:fix",
-    "ts-check": "pnpm -r ts-check",
+    "ts:check": "pnpm -r ts-check",
     "test": "pnpm -r test",
-    "code:checks": "pnpm lint:check && pnpm lint:check",
+    "code:checks": "pnpm prettier:check && pnpm lint:check && pnpm ts:check",
     "code:fixes": "pnpm prettier:fix && pnpm lint:fix",
     "postinstall": "pnpm --filter cloudflare build",
     "install-playwright": "playwright install --with-deps",

packages/cloudflare/env.d.ts

@@ -4,7 +4,7 @@ declare global {
       ASSETS: Fetcher;
       __NEXT_PRIVATE_STANDALONE_CONFIG?: string;
       SKIP_NEXT_APP_BUILD?: string;
-      [key: string]: string | Fetcher;
+      [key: string]: string;
     }
   }
 }

packages/cloudflare/package.json

@@ -7,7 +7,7 @@
     "build:watch": "tsup --watch src",
     "lint:check": "eslint",
     "lint:fix": "eslint --fix",
-    "ts-check": "tsc --noEmit",
+    "ts:check": "tsc --noEmit",
     "test": "vitest --run",
     "test:watch": "vitest"
   },

packages/cloudflare/src/cli/build/patches/investigated/update-webpack-chunks-file/get-chunk-installation-identifiers.ts

@@ -55,7 +55,7 @@ function getInstallChunkDeclaration(sourceFile: ts.SourceFile): ts.VariableDecla
 
       // the function we're looking for accesses its parameter three times, and it
       // accesses its `modules`, `ids` and `runtime` properties (in this order)
-      const parameterName = functionParameters[0]?.getText();
+      const parameterName = functionParameters[0]!.getText();
       const functionParameterAccessedProperties = arrowFunctionBodyBlock
         .getDescendantsOfKind(ts.SyntaxKind.PropertyAccessExpression)
         .filter(