Skip to content

Commit fa4ae18

Browse files
fixup! implement webpack chunks file updating using ast manipulation
update updateWebpackChunksFile comment
1 parent 0d304fd commit fa4ae18

File tree

1 file changed

+1
-3
lines changed
  • builder/src/build/patches/investigated/update-webpack-chunks-file

1 file changed

+1
-3
lines changed

builder/src/build/patches/investigated/update-webpack-chunks-file/index.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@ import { getUpdatedWebpackChunksFileContent } from "./get-updated-webpack-chunks
66
/**
77
* Fixes the webpack-runtime.js file by removing its webpack dynamic requires.
88
*
9-
* This hack is especially bad for two reasons:
10-
* - it requires setting `experimental.serverMinification` to `false` in the app's config file
11-
* - indicates that files inside the output directory still get a hold of files from the outside: `${nextjsAppPaths.standaloneAppServerDir}/webpack-runtime.js`
9+
* This hack is particularly bad as it indicates that files inside the output directory still get a hold of files from the outside: `${nextjsAppPaths.standaloneAppServerDir}/webpack-runtime.js`
1210
* so this shows that not everything that's needed to deploy the application is in the output directory...
1311
*/
1412
export async function updateWebpackChunksFile(nextjsAppPaths: NextjsAppPaths) {

0 commit comments

Comments
 (0)