🐛 Bug: everything that's needed should be in the output directory

[dario-piotrowicz]

The build does output a worker in the specified output directory (defaulting to .next-worker).

This directory should contain everything that's required to run the worker (assets included).

But this is not so, as there are clear signs that files within .next-worker make use of files outside of the directory (making the dev/deployment of unbundled workers (--no-bundle) impossible).

For example:

• the need to patch the webpack-runtime.js file
• the need to patch the pages.runtime.prod.js file

I'm not sure how those files are not getting bundled by the esbuild build step 😕

We should make sure that they are actually bundled in, or if that's not possible, everything that the worker requires should just need to live in the output directory and no external file/dependency should be needed (in other words, I think that we need to make sure that wrangler dev --no-bundle works).

[vicb]

@dario-piotrowicz I took a quick look at this and have some comments:

I'm not sure how those files are not getting bundled by the esbuild build step

At least part of why some file are not bundled by this pass is that they are not required.
You can see that patchRequire add requires after this first pass.

That is not the only patch adding deps that will be pick up by wrangler dev

I should tackle some of this over the next few days.

I think that we need to make sure that wrangler dev --no-bundle works

I think this is no more applicable.
The first pass of ESBuild is only for the server bundle.
OpenNext also generates a middleware bundle.
wrangler dev will stitch them together.

[vicb]

Is there a specific problem you think this was causing?

[dario-piotrowicz]

Is there a specific problem you think this was causing?

yes, I am pretty sure #148 and #219 do require this to be fixed before we can properly address those

I bet there are other problems that can't be fixed without this addressed

If needed I can go back to the issues and provide here a more detailed explanation

[dario-piotrowicz]

I think this is no more applicable. The first pass of ESBuild is only for the server bundle. OpenNext also generates a middleware bundle. wrangler dev will stitch them together.

I completely do no understand this.... are you saying we will always need to rely on wrangler's bundling? if that's the case that doesn't sound right at all to me, the two different bundles should both live under the .open-next directory and be sticked together by imports + something like find additional modules, no? Relying on bundling would also mean that we can't rely on lazy loading in our worker, which as we saw with next-on-pages can significantly improve performance (which we most likely need (#183))

[vicb]

are you saying we will always need to rely on wrangler's bundling?

Hum... I would say "plan" rather than "need" here.
Note that users can use their own bundling or no bundling if they need for some restricted use cases.
Probably something to document when things become more stable.

the two different bundles should both live under the .open-next directory

That's .open-next/middleware and .open-next/server-function

be sticked together by imports

That's in worker.ts

something like find additional modules
Relying on bundling would also mean that we can't rely on lazy loading in our worker

I believe lazy loading is possible in bundling mode using find_additional_modules?

[dario-piotrowicz]

I believe lazy loading is possible in bundling mode using find_additional_modules?

I think we already discussed about this and I think we confuse each other because "wrangler bundling" is just a confusing term in my opinion.

When I talk about bundling I mean in the true/strict sense, as in the fact you have N different js/ts files (which might include dependencies) and they all become a single js file that you can then send to Cloudflare, that's what I believe we do need not to depend on.

Bundling in the sense that we perform transformations on files and do some per-file bundling and whatnot, but allow lazy loading thought find_additional_modules is completely fine by me and I don't see any issue with that, as long as the base_dir is the .open-next directory (which is the directory that find_additional_modules traverses: Cloudflare docs)