-
Notifications
You must be signed in to change notification settings - Fork 73
Labels
bugSomething isn't workingSomething isn't working
Description
This repo imported the e2e tests from @opennextjs/aws
into examples/e2e
.
The unit tests can be executed by pnpm e2e-fix
We need to investigate the e2e failures
- Some are expected - i.e. ISR is not supported yet
- Some are not expected
Notes:
The pages-router
and app-pages-router
both have a build issue to investigate:
[WebServer] ▲ [WARNING] Using direct eval with a bundler is not recommended and may cause problems [direct-eval]
[WebServer]
[WebServer] .open-next/server-functions/default/examples/e2e/pages-router/handler.mjs:193620:43:
[WebServer] 193620 │ ... var deprecatedfn = eval("(function (" + args + ') ...
Related PRs:
- test: import app-router e2e tests from aws #289
- test: import pages-router from aws #290
- test: import app-pages-router from aws #292
Next steps:
For each of app-router
, pages-router
, and app-pages-router
in examples/e2e
:
- run
pnpm e2e-fix
- create sub-issue here for failing tests, skip the related test and comment with the issue:
// from
test("some failing test", () => {...});
// to
// https://github.com/opennextjs/opennextjs-cloudflare/issues/...
test.skip("some failing test", () => {...});
- once all failing tests are skip, we can rename the
e2e-fix
script toe2e
- then we should prioritize and tackle the sub issues
Sub-issues
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Type
Projects
Status
Done