From f11bfaa8092e3c6e59eb70bfef28e574f99c93f2 Mon Sep 17 00:00:00 2001 From: James Date: Tue, 18 Feb 2025 06:26:45 +0000 Subject: [PATCH] chore: unskip more isr e2es --- examples/e2e/app-pages-router/e2e/isr.test.ts | 2 +- examples/e2e/app-pages-router/e2e/pages_isr.test.ts | 2 +- examples/e2e/app-pages-router/open-next.config.ts | 6 ++++-- examples/e2e/app-pages-router/wrangler.json | 8 +++++++- examples/e2e/pages-router/e2e/isr.test.ts | 2 +- examples/e2e/pages-router/open-next.config.ts | 6 ++++-- examples/e2e/pages-router/wrangler.json | 8 +++++++- 7 files changed, 25 insertions(+), 9 deletions(-) diff --git a/examples/e2e/app-pages-router/e2e/isr.test.ts b/examples/e2e/app-pages-router/e2e/isr.test.ts index ed1f42cd..18d5a9ab 100644 --- a/examples/e2e/app-pages-router/e2e/isr.test.ts +++ b/examples/e2e/app-pages-router/e2e/isr.test.ts @@ -1,7 +1,7 @@ import { expect, test } from "@playwright/test"; // ISR is currently not supported: https://github.com/opennextjs/opennextjs-cloudflare/issues/105 -test.skip("Incremental Static Regeneration", async ({ page }) => { +test("Incremental Static Regeneration", async ({ page }) => { test.setTimeout(60000); await page.goto("/"); await page.locator('[href="/isr"]').click(); diff --git a/examples/e2e/app-pages-router/e2e/pages_isr.test.ts b/examples/e2e/app-pages-router/e2e/pages_isr.test.ts index 928eda96..8a67abae 100644 --- a/examples/e2e/app-pages-router/e2e/pages_isr.test.ts +++ b/examples/e2e/app-pages-router/e2e/pages_isr.test.ts @@ -1,7 +1,7 @@ import { expect, test } from "@playwright/test"; // ISR is currently not supported: https://github.com/opennextjs/opennextjs-cloudflare/issues/105 -test.skip("Incremental Static Regeneration", async ({ page }) => { +test("Incremental Static Regeneration", async ({ page }) => { test.setTimeout(60000); await page.goto("/"); await page.locator('[href="/pages_isr"]').click(); diff --git a/examples/e2e/app-pages-router/open-next.config.ts b/examples/e2e/app-pages-router/open-next.config.ts index d976688e..b8671cf5 100644 --- a/examples/e2e/app-pages-router/open-next.config.ts +++ b/examples/e2e/app-pages-router/open-next.config.ts @@ -1,14 +1,16 @@ import type { OpenNextConfig } from "@opennextjs/aws/types/open-next.js"; +import kvCache from "@opennextjs/cloudflare/kv-cache"; +import memoryQueue from "@opennextjs/cloudflare/memory-queue"; const config: OpenNextConfig = { default: { override: { wrapper: "cloudflare-node", converter: "edge", + incrementalCache: () => kvCache, + queue: () => memoryQueue, // Unused implementation - incrementalCache: "dummy", tagCache: "dummy", - queue: "dummy", }, }, diff --git a/examples/e2e/app-pages-router/wrangler.json b/examples/e2e/app-pages-router/wrangler.json index 0ea9def5..e599b5eb 100644 --- a/examples/e2e/app-pages-router/wrangler.json +++ b/examples/e2e/app-pages-router/wrangler.json @@ -7,5 +7,11 @@ "assets": { "directory": ".open-next/assets", "binding": "ASSETS" - } + }, + "kv_namespaces": [ + { + "binding": "NEXT_CACHE_WORKERS_KV", + "id": "" + } + ] } diff --git a/examples/e2e/pages-router/e2e/isr.test.ts b/examples/e2e/pages-router/e2e/isr.test.ts index e350d0bd..a05dad3f 100644 --- a/examples/e2e/pages-router/e2e/isr.test.ts +++ b/examples/e2e/pages-router/e2e/isr.test.ts @@ -1,7 +1,7 @@ import { expect, test } from "@playwright/test"; // ISR is currently not supported: https://github.com/opennextjs/opennextjs-cloudflare/issues/105 -test.skip("Incremental Static Regeneration", async ({ page }) => { +test("Incremental Static Regeneration", async ({ page }) => { test.setTimeout(45000); await page.goto("/"); await page.locator("[href='/isr/']").click(); diff --git a/examples/e2e/pages-router/open-next.config.ts b/examples/e2e/pages-router/open-next.config.ts index d976688e..b8671cf5 100644 --- a/examples/e2e/pages-router/open-next.config.ts +++ b/examples/e2e/pages-router/open-next.config.ts @@ -1,14 +1,16 @@ import type { OpenNextConfig } from "@opennextjs/aws/types/open-next.js"; +import kvCache from "@opennextjs/cloudflare/kv-cache"; +import memoryQueue from "@opennextjs/cloudflare/memory-queue"; const config: OpenNextConfig = { default: { override: { wrapper: "cloudflare-node", converter: "edge", + incrementalCache: () => kvCache, + queue: () => memoryQueue, // Unused implementation - incrementalCache: "dummy", tagCache: "dummy", - queue: "dummy", }, }, diff --git a/examples/e2e/pages-router/wrangler.json b/examples/e2e/pages-router/wrangler.json index 57ad53ee..d0f531f2 100644 --- a/examples/e2e/pages-router/wrangler.json +++ b/examples/e2e/pages-router/wrangler.json @@ -7,5 +7,11 @@ "assets": { "directory": ".open-next/assets", "binding": "ASSETS" - } + }, + "kv_namespaces": [ + { + "binding": "NEXT_CACHE_WORKERS_KV", + "id": "" + } + ] }