From a7be2a39abab4f7287df358cefa7e7e5d6e9a438 Mon Sep 17 00:00:00 2001 From: Dario Piotrowicz Date: Mon, 24 Feb 2025 11:13:27 +0000 Subject: [PATCH 1/2] un-skip the ssr loading e2e test in the `app-router` app --- examples/e2e/app-router/e2e/ssr.test.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/examples/e2e/app-router/e2e/ssr.test.ts b/examples/e2e/app-router/e2e/ssr.test.ts index ec6f0bfe..efc45e71 100644 --- a/examples/e2e/app-router/e2e/ssr.test.ts +++ b/examples/e2e/app-router/e2e/ssr.test.ts @@ -4,8 +4,7 @@ import { expect, test } from "@playwright/test"; // NOTE: We don't await page load b/c we want to see the Loading page -// loading.tsx doesn't currently work: https://github.com/opennextjs/opennextjs-cloudflare/issues/313 -test.skip("Server Side Render and loading.tsx", async ({ page }) => { +test("Server Side Render and loading.tsx", async ({ page }) => { test.setTimeout(600000); await page.goto("/"); await page.getByRole("link", { name: "SSR" }).click(); From 01c1e6b0fd00bffc865984d644ba5161da21952d Mon Sep 17 00:00:00 2001 From: Dario Piotrowicz Date: Mon, 24 Feb 2025 14:05:52 +0000 Subject: [PATCH 2/2] remove outdated comments --- examples/e2e/app-router/e2e/sse.test.ts | 3 --- examples/e2e/app-router/e2e/ssr.test.ts | 3 --- 2 files changed, 6 deletions(-) diff --git a/examples/e2e/app-router/e2e/sse.test.ts b/examples/e2e/app-router/e2e/sse.test.ts index c167e131..214abc18 100644 --- a/examples/e2e/app-router/e2e/sse.test.ts +++ b/examples/e2e/app-router/e2e/sse.test.ts @@ -1,6 +1,3 @@ -// NOTE: loading.tsx is currently broken on open - next -// This works locally but not on deployed apps - import { expect, test } from "@playwright/test"; // NOTE: We don't await page load b/c we want to see the Loading page diff --git a/examples/e2e/app-router/e2e/ssr.test.ts b/examples/e2e/app-router/e2e/ssr.test.ts index efc45e71..fe72027a 100644 --- a/examples/e2e/app-router/e2e/ssr.test.ts +++ b/examples/e2e/app-router/e2e/ssr.test.ts @@ -1,6 +1,3 @@ -// NOTE: loading.tsx is currently broken on open - next -// This works locally but not on deployed apps - import { expect, test } from "@playwright/test"; // NOTE: We don't await page load b/c we want to see the Loading page