Skip to content

Conversation

dario-piotrowicz
Copy link
Contributor

fixes #171

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2025

🦋 Changeset detected

Latest commit: 4259dfc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 24, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@409

commit: 4259dfc

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I have added a few comments

@dario-piotrowicz dario-piotrowicz force-pushed the dario/171/instrumentation-fix branch from c79fdf0 to 5644761 Compare February 25, 2025 09:11
@dario-piotrowicz dario-piotrowicz force-pushed the dario/171/instrumentation-fix branch from 983a9e0 to 065c772 Compare February 25, 2025 09:46
@dario-piotrowicz dario-piotrowicz force-pushed the dario/171/instrumentation-fix branch from 065c772 to 5268738 Compare February 25, 2025 09:50
@dario-piotrowicz dario-piotrowicz marked this pull request as draft February 25, 2025 09:51
@dario-piotrowicz
Copy link
Contributor Author

converted to draft as I just noticed that the patch does not work on Next 14

@dario-piotrowicz dario-piotrowicz force-pushed the dario/171/instrumentation-fix branch from 4ee0160 to e27cd2e Compare February 25, 2025 11:02
@dario-piotrowicz dario-piotrowicz force-pushed the dario/171/instrumentation-fix branch from b618c25 to 756b3b1 Compare February 25, 2025 11:25
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review February 25, 2025 12:33
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for tackling both N14 & N15 🎉

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@vicb vicb merged commit a604c85 into main Feb 25, 2025
7 checks passed
@vicb vicb deleted the dario/171/instrumentation-fix branch February 25, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate and support Next.js instrumentation

2 participants