🦋 Changeset detected

Latest commit: 284cc98

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@628

commit: 284cc98

Thanks for your contribution. While trying to use the main branch to fix the Sentry import issue (#587), I noticed that Sentry’s exports are not treated as hasBuildCondition:

https://github.com/getsentry/sentry-javascript/blob/eb495521e94f7808b26db5dc7e9c2f290fee6141/packages/nextjs/package.json#L18-L48

After checking the spec, it seems this is by design?

I think OpenNext is correct here:

getsentry/sentry-javascript@eb49552/packages/nextjs/package.json#L18-L48 has

  "exports": {
    "./package.json": "./package.json",
    ".": {
      "types": "./build/types/index.types.d.ts",
      // ...
      "workerd": {
        "import": "./build/esm/edge/index.js",
        "require": "./build/cjs/edge/index.js",
        "default": "./build/esm/edge/index.js"
      },

workerd looks to be a path here and the conditions are import, require, and default

workerd looks to be a path here and the conditions are import, require, and default

After reading the nested conditions section, I believe this should be interpreted as a case of nested conditions.

And workerd cannot be a path here because:

All paths defined in the "exports" must be relative file URLs starting with ./.

Meanwhile:

In node, conditions have very few restrictions, but specifically these include: [...]
2. They cannot start with "." since they may appear in places that also allow relative paths.

I tried npm i https://pkg.pr.new/@opennextjs/cloudflare@628 but this didn't fix the issue for me.

I have shared a minimum repro here - #623 (comment)