Skip to content

Commit 0a172ec

Browse files
authored
Merge branch 'main' into iterate-on-404-middleware
2 parents 62e7120 + 39b0fd4 commit 0a172ec

File tree

5 files changed

+817
-1112
lines changed

5 files changed

+817
-1112
lines changed

.github/workflows/run-tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,12 +118,12 @@ jobs:
118118
fail-fast: false
119119
matrix:
120120
shard: [1, 2, 3, 4, 5, 6, 7, 8]
121-
os: [ubuntu-latest, windows-latest]
121+
os: [ubuntu-latest, windows-2025]
122122
version: ${{ fromJson(needs.setup.outputs.matrix) }}
123123
exclude:
124-
- os: windows-latest
124+
- os: windows-2025
125125
version: '13.5.1'
126-
- os: windows-latest
126+
- os: windows-2025
127127
version: '14.2.15'
128128
runs-on: ${{ matrix.os }}
129129
steps:

.github/workflows/test-e2e.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ env:
3838
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
3939
NETLIFY_SITE_ID: 1d5a5c76-d445-4ae5-b694-b0d3f2e2c395
4040
NEXT_TEST_CONTINUE_ON_ERROR: 1
41+
# There's no benefit to cleaning up local site fixture copies in tmp dirs in CI. It wastes precious time.
42+
# Deleting deploys is also unnecessary as they will get cleaned up naturally by Netlify.
43+
E2E_PERSIST: 1
4144
next-path: next.js
4245
runtime-path: opennextjs-netlify
4346
GH_TOKEN: ${{ github.token }}
@@ -198,6 +201,10 @@ jobs:
198201
NODE_ENV: production
199202
NEXT_EXTERNAL_TESTS_FILTERS: ${{ steps.test-filters.outputs.filters }}
200203
NEXT_TEST_SKIP_RETRY_MANIFEST: ${{ steps.test-filters.outputs.skip-retry }}
204+
# Use a unique alias per test matrix group and shard. Otherwise, a deploy within
205+
# one job may wait for deploys in other jobs (only one deploy may be in progress for
206+
# a given alias at a time), resulting in cascading timeouts.
207+
DEPLOY_ALIAS: vercel-next-e2e-${{ matrix.version_spec.selector }}-${{ matrix.group }}
201208
run: node run-tests.js -g ${{ matrix.group }}/${{ needs.setup.outputs.total }} -c ${TEST_CONCURRENCY} --type e2e
202209
working-directory: ${{ env.next-path }}
203210

0 commit comments

Comments
 (0)