test: initial build variants setup

Author: pieh

tests/e2e/edge-middleware.test.ts

@@ -1,32 +1,74 @@
 import { expect, Response } from '@playwright/test'
-import { nextVersionSatisfies } from '../utils/next-version-helpers.mjs'
+import { hasNodeMiddlewareSupport, nextVersionSatisfies } from '../utils/next-version-helpers.mjs'
 import { test } from '../utils/playwright-helpers.js'
 import { getImageSize } from 'next/dist/server/image-optimizer.js'
+import type { Fixture } from '../utils/create-e2e-fixture.js'
 
 type ExtendedWindow = Window & {
   didReload?: boolean
 }
 
-test('Runs edge middleware', async ({ page, middleware }) => {
-  await page.goto(`${middleware.url}/test/redirect`)
+for (const { expectedRuntime, label, testWithSwitchableMiddlewareRuntime } of [
+  {
+    expectedRuntime: 'edge-runtime',
+    label: 'Edge runtime middleware',
+    testWithSwitchableMiddlewareRuntime: test.extend<{}, { edgeOrNodeMiddleware: Fixture }>({
+      edgeOrNodeMiddleware: [
+        async ({ middleware }, use) => {
+          await use(middleware)
+        },
+        {
+          scope: 'worker',
+        },
+      ],
+    }),
+  },
+  hasNodeMiddlewareSupport()
+    ? {
+        expectedRuntime: 'node',
+        label: 'Node.js runtime middleware',
+        testWithSwitchableMiddlewareRuntime: test.extend<{}, { edgeOrNodeMiddleware: Fixture }>({
+          edgeOrNodeMiddleware: [
+            async ({ middlewareNode }, use) => {
+              await use(middlewareNode)
+            },
+            {
+              scope: 'worker',
+            },
+          ],
+        }),
+      }
+    : undefined,
+].filter(function isDefined<T>(argument: T | undefined): argument is T {
+  return typeof argument !== 'undefined'
+})) {
+  const test = testWithSwitchableMiddlewareRuntime
+
+  test.describe(label, () => {
+    test('Runs middleware', async ({ page, edgeOrNodeMiddleware }) => {
+      const res = await page.goto(`${edgeOrNodeMiddleware.url}/test/redirect`)
+
+      await expect(page).toHaveTitle('Simple Next App')
+
+      const h1 = page.locator('h1')
+      await expect(h1).toHaveText('Other')
+    })
 
-  await expect(page).toHaveTitle('Simple Next App')
+    test('Does not run middleware at the origin', async ({ page, edgeOrNodeMiddleware }) => {
+      const res = await page.goto(`${edgeOrNodeMiddleware.url}/test/next`)
 
-  const h1 = page.locator('h1')
-  await expect(h1).toHaveText('Other')
-})
-
-test('Does not run edge middleware at the origin', async ({ page, middleware }) => {
-  const res = await page.goto(`${middleware.url}/test/next`)
+      expect(await res?.headerValue('x-deno')).toBeTruthy()
+      expect(await res?.headerValue('x-node')).toBeNull()
 
-  expect(await res?.headerValue('x-deno')).toBeTruthy()
-  expect(await res?.headerValue('x-node')).toBeNull()
+      await expect(page).toHaveTitle('Simple Next App')
 
-  await expect(page).toHaveTitle('Simple Next App')
+      const h1 = page.locator('h1')
+      await expect(h1).toHaveText('Message from middleware: hello')
 
-  const h1 = page.locator('h1')
-  await expect(h1).toHaveText('Message from middleware: hello')
-})
+      expect(await res?.headerValue('x-runtime')).toEqual(expectedRuntime)
+    })
+  })
+}
 
 test('does not run middleware again for rewrite target', async ({ page, middleware }) => {
   const direct = await page.goto(`${middleware.url}/test/rewrite-target`)

tests/fixtures/hello-world-turbopack/middleware.ts

@@ -9,5 +9,4 @@ export function middleware(request: NextRequest) {
 
 export const config = {
   matcher: '/middleware/:path*',
-  runtime: 'nodejs',
 }

tests/fixtures/middleware-conditions/middleware.ts

@@ -23,5 +23,4 @@ export const config = {
       locale: false,
     },
   ],
-  runtime: 'nodejs',
 }

tests/fixtures/middleware-i18n-excluded-paths/middleware.ts

@@ -33,5 +33,4 @@ export const config = {
      */
     '/((?!api|excluded|_next/static|_next/image|favicon.ico|sitemap.xml|robots.txt).*)',
   ],
-  runtime: 'nodejs',
 }

tests/fixtures/middleware-i18n-skip-normalize/middleware.js

@@ -89,7 +89,3 @@ export async function middleware(request) {
     })
   }
 }
-
-export const config = {
-  runtime: 'nodejs',
-}

tests/fixtures/middleware-i18n/middleware.js

@@ -114,7 +114,3 @@ export async function middleware(request) {
     })
   }
 }
-
-export const config = {
-  runtime: 'nodejs',
-}