ci: don't install fixture's deps if next version requierment is not satisfied

Author: pieh

tests/prepare.mjs

@@ -60,10 +60,12 @@ const promises = fixtures.map((fixture) =>
     })
     await Promise.all(publishDirectories.map((dir) => rm(dir, { recursive: true, force: true })))
 
-    if (NEXT_VERSION !== 'latest') {
-      await setNextVersionInFixture(cwd, NEXT_VERSION, {
-        logPrefix: `[${fixture}] `,
-      })
+    const fixtureNextVersionSatisfied = await setNextVersionInFixture(cwd, NEXT_VERSION, {
+      logPrefix: `[${fixture}] `,
+    })
+
+    if (!fixtureNextVersionSatisfied) {
+      return
     }
 
     let cmd = ``
@@ -104,12 +106,10 @@ const promises = fixtures.map((fixture) =>
     }
     output.stderr?.pipe(addPrefix).pipe(process.stderr)
     return output.finally(async () => {
-      if (NEXT_VERSION !== 'latest') {
-        await setNextVersionInFixture(cwd, 'latest', {
-          logPrefix: `[${fixture}] `,
-          operation: 'revert',
-        })
-      }
+      await setNextVersionInFixture(cwd, 'latest', {
+        logPrefix: `[${fixture}] `,
+        operation: 'revert',
+      })
       if (output.exitCode !== 0) {
         const errorMessage = `[${fixture}] 🚨 Failed to install dependencies or build a fixture`
         console.error(errorMessage)

tests/utils/create-e2e-fixture.ts

@@ -77,9 +77,7 @@ export const createE2EFixture = async (fixture: string, config: E2EConfig = {})
       copyFixture(fixture, isolatedFixtureRoot, config),
     ])
 
-    if (NEXT_VERSION !== 'latest') {
-      await setNextVersionInFixture(isolatedFixtureRoot, NEXT_VERSION)
-    }
+    await setNextVersionInFixture(isolatedFixtureRoot, NEXT_VERSION)
     await installRuntime(packageName, isolatedFixtureRoot, config)
     await verifyFixture(isolatedFixtureRoot, config)
 

tests/utils/fixture.ts

@@ -39,9 +39,7 @@ const eszipHelper = join(actualCwd, 'tools/deno/eszip.ts')
 
 async function installDependencies(cwd: string) {
   const NEXT_VERSION = process.env.NEXT_VERSION ?? 'latest'
-  if (NEXT_VERSION !== 'latest') {
-    await setNextVersionInFixture(cwd, NEXT_VERSION, { silent: true })
-  }
+  await setNextVersionInFixture(cwd, NEXT_VERSION, { silent: true })
 
   const { packageManager } = JSON.parse(await readFile(join(cwd, 'package.json'), 'utf8'))
   if (packageManager?.startsWith('pnpm')) {

tests/utils/next-version-helpers.mjs

@@ -70,7 +70,7 @@ export function nextVersionRequiresReact19(version) {
  * @param {'update' | 'revert'} [options.operation] This just informs log output wording, otherwise it has no effect
  * @param {boolean} [options.silent] Doesn't produce any logs if truthy
  * @param {boolean} [options.updateReact] Update React version to match Next version
- * @returns {Promise<void>}
+ * @returns {Promise<boolean>} true if fixture's next version requirements are satisfied
  */
 export async function setNextVersionInFixture(
   cwd,
@@ -87,40 +87,67 @@ export async function setNextVersionInFixture(
   // if resolved version is different from version, we add it to the log to provide additional details
   const nextVersionForLogs = `next@${version}${resolvedVersion !== version ? ` (${resolvedVersion})` : ``}`
 
-  if (!silent) {
-    console.log(
-      `${logPrefix}▲ ${operation === 'revert' ? 'Reverting' : 'Updating'} to ${nextVersionForLogs}...`,
-    )
-  }
-
   const packageJsons = await fg.glob(['**/package.json', '!**/node_modules'], {
     cwd,
     absolute: true,
   })
 
   const isSemverVersion = valid(resolvedVersion)
 
-  await Promise.all(
+  const areNextVersionConstraintsSatisfied = await Promise.all(
     packageJsons.map(async (packageJsonPath) => {
       const packageJson = JSON.parse(await readFile(packageJsonPath, 'utf8'))
       if (packageJson.dependencies?.next) {
         const versionConstraint = packageJson.test?.dependencies?.next
         // We can't use semver to check "canary" or "latest", so we use a fake future minor version
         const checkVersion = isSemverVersion ? resolvedVersion : FUTURE_NEXT_PATCH_VERSION
+        console.log({
+          checkVersion,
+          versionConstraint,
+          isNextCanary: isNextCanary(),
+        })
         if (
           operation === 'update' &&
           versionConstraint &&
-          !satisfies(checkVersion, versionConstraint, { includePrerelease: true }) &&
+          !(versionConstraint === 'canary'
+            ? isNextCanary()
+            : satisfies(checkVersion, versionConstraint, { includePrerelease: true })) &&
           version !== versionConstraint
         ) {
           if (!silent) {
             console.log(
               `${logPrefix}⏩ Skipping '${packageJson.name}' because it requires next@${versionConstraint}`,
             )
           }
-          return
+          return false
         }
+      }
+      return true
+    }),
+  )
+
+  if (areNextVersionConstraintsSatisfied.some((isSatisfied) => !isSatisfied)) {
+    // at least one next version constraint is not satisfied so we skip this fixture
+    return false
+  }
+
+  if (process.env.NEXT_VERSION ?? 'latest' === 'latest') {
+    // latest is default so we don't want to make any changes
+    return true
+  }
+
+  if (!silent) {
+    console.log(
+      `${logPrefix}▲ ${operation === 'revert' ? 'Reverting' : 'Updating'} to ${nextVersionForLogs}...`,
+    )
+  }
+
+  await Promise.all(
+    packageJsons.map(async (packageJsonPath) => {
+      const packageJson = JSON.parse(await readFile(packageJsonPath, 'utf8'))
+      if (packageJson.dependencies?.next) {
         packageJson.dependencies.next = version
+        const checkVersion = isSemverVersion ? resolvedVersion : FUTURE_NEXT_PATCH_VERSION
 
         const { stdout } = await execaCommand(
           `npm info next@${resolvedVersion} peerDependencies --json`,
@@ -172,4 +199,6 @@ export async function setNextVersionInFixture(
       `${logPrefix}▲ ${operation === 'revert' ? 'Reverted' : 'Updated'} to ${nextVersionForLogs}`,
     )
   }
+
+  return true
 }