test: export skew protection config and assert that configuration file was written with it instead of inlining it again in test

Author: pieh

src/build/skew-protection.test.ts

@@ -9,6 +9,7 @@ import {
   EnabledOrDisabledReason,
   setSkewProtection,
   shouldEnableSkewProtection,
+  skewProtectionConfig,
 } from './skew-protection.js'
 
 // Mock fs promises
@@ -298,27 +299,7 @@ describe('setSkewProtection', () => {
     expect(mkdir).toHaveBeenCalledWith('/test/path', { recursive: true })
     expect(writeFile).toHaveBeenCalledWith(
       '/test/path/skew-protection.json',
-      JSON.stringify(
-        {
-          patterns: ['.*'],
-          sources: [
-            {
-              type: 'cookie',
-              name: '__vdpl',
-            },
-            {
-              type: 'header',
-              name: 'X-Deployment-Id',
-            },
-            {
-              type: 'query',
-              name: 'dpl',
-            },
-          ],
-        },
-        null,
-        2,
-      ),
+      JSON.stringify(skewProtectionConfig),
     )
   })
 

src/build/skew-protection.ts

@@ -20,6 +20,24 @@ const optInOptions = new Set([
   EnabledOrDisabledReason.OPT_IN_ENV_VAR,
 ])
 
+export const skewProtectionConfig = {
+  patterns: ['.*'],
+  sources: [
+    {
+      type: 'cookie',
+      name: '__vdpl',
+    },
+    {
+      type: 'header',
+      name: 'X-Deployment-Id',
+    },
+    {
+      type: 'query',
+      name: 'dpl',
+    },
+  ],
+}
+
 export function shouldEnableSkewProtection(ctx: PluginContext) {
   let enabledOrDisabledReason: EnabledOrDisabledReason = EnabledOrDisabledReason.OPT_OUT_DEFAULT
 
@@ -85,28 +103,5 @@ export const setSkewProtection = async (ctx: PluginContext, span: Span) => {
   await mkdir(dirname(ctx.skewProtectionConfigPath), {
     recursive: true,
   })
-  await writeFile(
-    ctx.skewProtectionConfigPath,
-    JSON.stringify(
-      {
-        patterns: ['.*'],
-        sources: [
-          {
-            type: 'cookie',
-            name: '__vdpl',
-          },
-          {
-            type: 'header',
-            name: 'X-Deployment-Id',
-          },
-          {
-            type: 'query',
-            name: 'dpl',
-          },
-        ],
-      },
-      null,
-      2,
-    ),
-  )
+  await writeFile(ctx.skewProtectionConfigPath, JSON.stringify(skewProtectionConfig))
 }