|
1 | 1 | ## Feedback
|
2 | 2 |
|
3 | 3 | - Files from `public` directory not listed in `outputs.staticFiles`. Should they be?
|
4 |
| -- `routes.headers` does not contain immutable cache-control headers for `_next/static` |
| 4 | +- `routes.headers` does not contain immutable cache-control headers for `_next/static`. Should those |
| 5 | + be included? |
5 | 6 | - In `onBuildComplete` - `config.images.remotePatterns` type is `(RemotePattern | URL)[]` but in
|
6 | 7 | reality `URL` inputs are converted to `RemotePattern` so type should be just `RemotePattern[]` in
|
7 | 8 | `onBuildComplete` (this would require different config type for `modifyConfig` (allow inputs
|
|
14 | 15 | or `wasm` (tho wasm files are included in assets, so I think I have a way to support those as-is,
|
15 | 16 | but need to to make some assumption about using extension-less file name of wasm file as
|
16 | 17 | identifier)
|
17 |
| -- `outputs.staticFiles` (i18n enabled) custom fully static (no `getStaticProps`) `/pages/404.js` |
18 |
| - `filePath` point to not existing file (it doesn't have i18n locale prefix in `staticFiles` array, |
19 |
| - actual 404.html are written to i18n locale prefixed directories) |
20 |
| -- `outputs.staticFiles` (i18n enabled) custom `/pages/404.js` with `getStaticProps` result in fatal |
21 |
| - `Error: Invariant: failed to find source route /en/404 for prerender /en/404` directly from |
| 18 | +- `outputs.staticFiles` (i18n enabled) custom fully static (no `getStaticProps`) `/pages/*` |
| 19 | + `filePath` point to not existing file - see repro at https://github.com/pieh/i18n-adapters |
| 20 | +- `outputs.staticFiles` (i18n enabled) custom `/pages/*` with `getStaticProps` result in fatal |
| 21 | + `Error: Invariant: failed to find source route /en(/*) for prerender /en(/*)` directly from |
22 | 22 | Next.js:
|
23 | 23 |
|
24 | 24 | ```
|
|
31 | 31 | (additionally - invariant is reported as failing to run `onBuildComplete` from adapter, but it
|
32 | 32 | happens before adapter's `onBuildComplete` runs, would be good to clear this up a bit so users
|
33 | 33 | could report issues in correct place in such cases. Not that important for nearest future / not
|
34 |
| - blocking) |
| 34 | + blocking). |
| 35 | + |
| 36 | + See repro at https://github.com/pieh/i18n-adapters (it's same as for point above, need to |
| 37 | + uncomment `getStaticProps` in one of the pages in repro to see this case) |
35 | 38 |
|
36 | 39 | - `output: 'export'` case seems to produce outputs as if it was not export mode (for example having
|
37 | 40 | non-empty `outputs.appPages` or `outputs.prerenders`). To not have special handling for that in
|
|
0 commit comments