Skip to content

Commit 89a0189

Browse files
authored
Merge pull request #123 from openobserve/dev
feat: add 'is_control' attribute to variant schema and remove unused …
2 parents a374c22 + 1d80261 commit 89a0189

File tree

2 files changed

+5
-69
lines changed

2 files changed

+5
-69
lines changed

src/components/ab-experiments-component/variant.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@
2323
},
2424
"variantId": {
2525
"type": "string"
26+
},
27+
"is_control": {
28+
"type": "boolean",
29+
"default": false
2630
}
2731
}
2832
}

types/generated/components.d.ts

Lines changed: 1 addition & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -15,55 +15,6 @@ export interface AbExperimentsComponentGoal extends Struct.ComponentSchema {
1515
};
1616
}
1717

18-
export interface AbExperimentsComponentHtmlChange
19-
extends Struct.ComponentSchema {
20-
collectionName: 'components_ab_experiments_html_changes';
21-
info: {
22-
description: 'HTML content change for experiment variants';
23-
displayName: 'HTML Change';
24-
};
25-
attributes: {
26-
html: Schema.Attribute.Text & Schema.Attribute.Required;
27-
selector: Schema.Attribute.String & Schema.Attribute.Required;
28-
type: Schema.Attribute.Enumeration<['html']> &
29-
Schema.Attribute.Required &
30-
Schema.Attribute.DefaultTo<'html'>;
31-
};
32-
}
33-
34-
export interface AbExperimentsComponentImageChange
35-
extends Struct.ComponentSchema {
36-
collectionName: 'components_ab_experiments_image_changes';
37-
info: {
38-
description: 'Image change for experiment variants';
39-
displayName: 'Image Change';
40-
};
41-
attributes: {
42-
image: Schema.Attribute.Media<'images' | 'files' | 'videos' | 'audios'> &
43-
Schema.Attribute.Required;
44-
selector: Schema.Attribute.String & Schema.Attribute.Required;
45-
type: Schema.Attribute.Enumeration<['image']> &
46-
Schema.Attribute.Required &
47-
Schema.Attribute.DefaultTo<'image'>;
48-
};
49-
}
50-
51-
export interface AbExperimentsComponentStyleChange
52-
extends Struct.ComponentSchema {
53-
collectionName: 'components_ab_experiments_style_changes';
54-
info: {
55-
description: 'CSS style change for experiment variants';
56-
displayName: 'Style Change';
57-
};
58-
attributes: {
59-
selector: Schema.Attribute.String & Schema.Attribute.Required;
60-
style: Schema.Attribute.Text & Schema.Attribute.Required;
61-
type: Schema.Attribute.Enumeration<['style']> &
62-
Schema.Attribute.Required &
63-
Schema.Attribute.DefaultTo<'style'>;
64-
};
65-
}
66-
6718
export interface AbExperimentsComponentTargetingRules
6819
extends Struct.ComponentSchema {
6920
collectionName: 'components_ab_experiments_targeting_rules';
@@ -84,22 +35,6 @@ export interface AbExperimentsComponentTargetingRules
8435
};
8536
}
8637

87-
export interface AbExperimentsComponentTextChange
88-
extends Struct.ComponentSchema {
89-
collectionName: 'components_ab_experiments_text_changes';
90-
info: {
91-
description: 'Text content change for experiment variants';
92-
displayName: 'Text Change';
93-
};
94-
attributes: {
95-
selector: Schema.Attribute.String & Schema.Attribute.Required;
96-
type: Schema.Attribute.Enumeration<['text']> &
97-
Schema.Attribute.Required &
98-
Schema.Attribute.DefaultTo<'text'>;
99-
value: Schema.Attribute.Text & Schema.Attribute.Required;
100-
};
101-
}
102-
10338
export interface AbExperimentsComponentUrlRule extends Struct.ComponentSchema {
10439
collectionName: 'components_ab_experiments_url_rules';
10540
info: {
@@ -126,6 +61,7 @@ export interface AbExperimentsComponentVariant extends Struct.ComponentSchema {
12661
'ab-experiments-component.variant-change',
12762
true
12863
>;
64+
is_control: Schema.Attribute.Boolean & Schema.Attribute.DefaultTo<false>;
12965
name: Schema.Attribute.String & Schema.Attribute.Required;
13066
variantId: Schema.Attribute.String;
13167
weight: Schema.Attribute.Decimal &
@@ -1909,11 +1845,7 @@ declare module '@strapi/strapi' {
19091845
export module Public {
19101846
export interface ComponentSchemas {
19111847
'ab-experiments-component.goal': AbExperimentsComponentGoal;
1912-
'ab-experiments-component.html-change': AbExperimentsComponentHtmlChange;
1913-
'ab-experiments-component.image-change': AbExperimentsComponentImageChange;
1914-
'ab-experiments-component.style-change': AbExperimentsComponentStyleChange;
19151848
'ab-experiments-component.targeting-rules': AbExperimentsComponentTargetingRules;
1916-
'ab-experiments-component.text-change': AbExperimentsComponentTextChange;
19171849
'ab-experiments-component.url-rule': AbExperimentsComponentUrlRule;
19181850
'ab-experiments-component.variant': AbExperimentsComponentVariant;
19191851
'ab-experiments-component.variant-change': AbExperimentsComponentVariantChange;

0 commit comments

Comments
 (0)