New chat always enabled (#1107)

Author: alexandrudanpop

packages/react-ui/src/app/features/ai/assistant-ui/assistant-ui-chat.tsx

@@ -41,7 +41,6 @@ const AssistantUiChat = ({
     shouldRenderChat,
     openChatResponse,
     isLoading,
-    hasMessages,
     createNewChat,
   } = useAssistantChat({
     chatId,
@@ -83,7 +82,6 @@ const AssistantUiChat = ({
       runtime={runtime}
       onNewChat={createNewChat}
       title={title}
-      enableNewChat={hasMessages}
       availableModels={availableModels}
       onModelSelected={onModelSelected}
       isModelSelectorLoading={isModelSelectorLoading}

packages/react-ui/src/app/features/ai/lib/assistant-ui-chat-hook.ts

@@ -148,8 +148,6 @@ export const useAssistantChat = (props: UseAssistantChatProps) => {
 
   const runtime = useChatRuntime(runtimeConfig);
 
-  const [hasMessages, setHasMessages] = useState(!!openChatResponse?.messages);
-
   useEffect(() => {
     if (pendingConversation && runtime && shouldRenderChat) {
       if (pendingConversation.chatId !== chatId) {
@@ -182,7 +180,6 @@ export const useAssistantChat = (props: UseAssistantChatProps) => {
           await aiChatApi.delete(oldChatId);
         }
       }
-      setHasMessages(false);
     } catch (error) {
       toast({
         title: t('There was an error creating the new chat, please try again'),
@@ -194,20 +191,11 @@ export const useAssistantChat = (props: UseAssistantChatProps) => {
     }
   }, [chatId, onChatIdChange, runtime.thread, selectedStep, flowVersion]);
 
-  useEffect(() => {
-    const unsubscribe = runtime.thread.subscribe(() => {
-      setHasMessages(!!runtime.thread.getState().messages?.length);
-    });
-
-    return () => unsubscribe();
-  }, [runtime.thread]);
-
   return {
     runtime,
     shouldRenderChat,
     isLoading,
     openChatResponse,
-    hasMessages,
     createNewChat,
   };
 };

packages/react-ui/src/app/features/builder/ai-chat/step-settings-assistant-ui-chat.tsx

@@ -36,8 +36,10 @@ const StepSettingsAssistantUiChat = ({
     state.applyMidpanelAction,
   ]);
 
-  const { runtime, createNewChat, hasMessages, onInject } =
-    useStepSettingsAssistantChat(flowVersion, selectedStep);
+  const { runtime, createNewChat, onInject } = useStepSettingsAssistantChat(
+    flowVersion,
+    selectedStep,
+  );
 
   const onToggleContainerSizeState = useCallback(
     (size: AiCliChatContainerSizeState) => {
@@ -76,7 +78,6 @@ const StepSettingsAssistantUiChat = ({
       parentWidth={middlePanelSize.width}
       showAiChat={showAiChat}
       onCloseClick={onCloseClick}
-      enableNewChat={hasMessages}
       handleInject={onInject}
       onNewChatClick={createNewChat}
       containerSize={aiContainerSize}

packages/ui-components/src/components/ai-chat-container/step-settings-assistant-ui-chat-container.tsx

@@ -24,7 +24,6 @@ type StepSettingsAssistantUiChatContainerProps = {
   onCloseClick: () => void;
   onNewChatClick: () => void;
   containerSize: AiCliChatContainerSizeState;
-  enableNewChat: boolean;
   toggleContainerSizeState: (state: AiCliChatContainerSizeState) => void;
   className?: string;
   isModelSelectorLoading: boolean;
@@ -44,7 +43,6 @@ const StepSettingsAssistantUiChatContainer = ({
   onCloseClick,
   onNewChatClick,
   containerSize,
-  enableNewChat,
   toggleContainerSizeState,
   className,
   isModelSelectorLoading,
@@ -99,7 +97,6 @@ const StepSettingsAssistantUiChatContainer = ({
         runtime={runtime}
         onClose={onCloseClick}
         onNewChat={onNewChatClick}
-        enableNewChat={enableNewChat}
         availableModels={availableModels}
         theme={theme}
         title={t('AI Chat')}

packages/ui-components/src/components/assistant-ui/assistant-top-bar.tsx

@@ -7,15 +7,13 @@ import { Button } from '../../ui/button';
 type AssistantTopBarProps = {
   onClose: () => void;
   onNewChat: () => void;
-  enableNewChat: boolean;
   title?: string;
   children: ReactNode;
 };
 
 const AssistantTopBar = ({
   onNewChat,
   onClose,
-  enableNewChat,
   title,
   children,
 }: AssistantTopBarProps) => {
@@ -28,7 +26,6 @@ const AssistantTopBar = ({
               e.stopPropagation();
               onNewChat();
             }}
-            disabled={!enableNewChat}
             variant="secondary"
             size="icon"
             className="text-outline size-[36px]"

packages/ui-components/src/components/assistant-ui/assistant-ui-chat-container.tsx

@@ -19,7 +19,6 @@ type AssistantUiChatContainerProps = {
 const AssistantUiChatContainer = ({
   onClose,
   onNewChat,
-  enableNewChat,
   runtime,
   title,
   availableModels,
@@ -39,12 +38,7 @@ const AssistantUiChatContainer = ({
 
   return (
     <div className="h-full w-full flex flex-col bg-background overflow-hidden">
-      <AssistantTopBar
-        onClose={onClose}
-        onNewChat={onNewChat}
-        enableNewChat={enableNewChat}
-        title={title}
-      >
+      <AssistantTopBar onClose={onClose} onNewChat={onNewChat} title={title}>
         {children}
       </AssistantTopBar>
       <AssistantRuntimeProvider runtime={runtime}>

packages/ui-components/src/stories/assistant-ui/assistant-top-bar.stories.tsx

@@ -25,7 +25,6 @@ const meta = {
   args: {
     onClose: action('Close clicked'),
     onNewChat: action('New chat clicked'),
-    enableNewChat: true,
     title: 'AI Assistant',
     children: null,
   },
@@ -36,10 +35,6 @@ const meta = {
     onNewChat: {
       description: 'Function called when the new chat button is clicked',
     },
-    enableNewChat: {
-      description: 'Whether the new chat button is enabled',
-      control: 'boolean',
-    },
     children: {
       description: 'Optional elements to render in the header',
     },
@@ -69,16 +64,6 @@ type Story = StoryObj<typeof meta>;
  */
 export const Default: Story = {};
 
-/**
- * AssistantTopBar with the new chat button disabled.
- * This demonstrates how the component appears when starting a new chat is not allowed.
- */
-export const NewChatDisabled: Story = {
-  args: {
-    enableNewChat: false,
-  },
-};
-
 /**
  * AssistantTopBar with additional action buttons.
  * This demonstrates how the component can be extended with custom controls.
@@ -133,7 +118,6 @@ export const WithSingleButton: Story = {
  */
 export const ComplexExample: Story = {
   args: {
-    enableNewChat: false,
     children: (
       <>
         <Button