Complete TablesServerContext integration in table lookup functions (#1632)

Fixes OPS-3021, OPS-3022, OPS-3023, OPS-3024, OPS-3025, OPS-3026.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Refactor**
* Table-related APIs now operate with explicit server/project context
and authentication, improving correct scoping and access to
project-specific tables.
* Table lookup now consistently resolves duplicates by stable selection
and returns normalized table descriptors.

* **Chores**
* Seeding and startup processes now use the default project DB token
when locating project tables.

* **Tests**
  * Tests updated to support and mock the new context-aware table flows.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Marcelo Gonçalves <[email protected]>

Author: cezudas

packages/openops/src/lib/openops-tables/openops-tables-common-properties.ts

@@ -16,8 +16,8 @@ export function openopsTablesDropdownProperty(): any {
     displayName: 'Table',
     refreshers: [],
     required: true,
-    options: async () => {
-      const tables = await getTableNames();
+    options: async (_, { server }) => {
+      const tables = await getTableNames(server);
 
       return {
         disabled: false,

packages/openops/src/lib/openops-tables/tables.ts

@@ -1,26 +1,24 @@
+import { AxiosHeaders } from 'axios';
 import { makeOpenOpsTablesGet } from '../openops-tables/requests-helpers';
-import { getDefaultDatabaseId } from './applications-service';
-import { authenticateDefaultUserInOpenOpsTables } from './auth-user';
-import { TablesServerContext } from './context-helpers';
+import { TablesServerContext, resolveTokenProvider } from './context-helpers';
 import { createAxiosHeaders } from './create-axios-headers';
 
 async function getTables(
-  token: string,
   databaseId: number,
+  authenticationHeader: AxiosHeaders,
 ): Promise<OpenOpsTable[]> {
-  const authenticationHeader = createAxiosHeaders(token);
   const getTablesResult = await makeOpenOpsTablesGet<OpenOpsTable[]>(
     `api/database/tables/database/${databaseId}/`,
     authenticationHeader,
   );
-  return getTablesResult.flatMap((item) => item);
+  return getTablesResult.flat();
 }
 
 export async function getTableIdByTableName(
   tableName: string,
-  _tablesServerContext: TablesServerContext,
+  tablesServerContext: TablesServerContext,
 ): Promise<number> {
-  const table = await getTableByName(tableName);
+  const table = await getTableByName(tableName, tablesServerContext);
 
   if (!table) {
     throw new Error(`Table '${tableName}' not found`);
@@ -31,26 +29,34 @@ export async function getTableIdByTableName(
 
 export async function getTableByName(
   tableName: string,
+  tablesServerContext: TablesServerContext,
 ): Promise<OpenOpsTable | undefined> {
-  const tables = await getAvailableTablesInOpenopsTables();
+  const tables = await getAvailableTablesInOpenopsTables(tablesServerContext);
 
   const table = tables.find((t) => t.name === tableName);
 
   return table;
 }
 
-export async function getTableNames(): Promise<string[]> {
-  const tables = await getAvailableTablesInOpenopsTables();
+export async function getTableNames(
+  tablesServerContext: TablesServerContext,
+): Promise<string[]> {
+  const tables = await getAvailableTablesInOpenopsTables(tablesServerContext);
 
   return tables.map((t) => t.name);
 }
 
-async function getAvailableTablesInOpenopsTables(): Promise<OpenOpsTable[]> {
-  const { token } = await authenticateDefaultUserInOpenOpsTables();
+async function getAvailableTablesInOpenopsTables(
+  serverContext: TablesServerContext,
+): Promise<OpenOpsTable[]> {
+  const tokenOrResolver = await resolveTokenProvider(serverContext);
 
-  const tablesDatabaseId = await getDefaultDatabaseId(token);
+  const authenticationHeader = createAxiosHeaders(tokenOrResolver);
 
-  const tables = await getTables(token, tablesDatabaseId);
+  const tables = await getTables(
+    serverContext.tablesDatabaseId,
+    authenticationHeader,
+  );
 
   return getDistinctTableNames(tables);
 }

packages/openops/test/openops-tables/tables.test.ts

@@ -15,10 +15,6 @@ jest.mock('../../src/lib/openops-tables/auth-user', () => ({
     authenticateDefaultUserInOpenOpsTablesMock,
 }));
 
-jest.mock('../../src/lib/openops-tables/applications-service', () => ({
-  getDefaultDatabaseId: jest.fn().mockResolvedValue(1),
-}));
-
 jest.mock('@openops/server-shared', () => ({
   ...jest.requireActual('@openops/server-shared'),
   system: {
@@ -58,7 +54,7 @@ describe('get table names', () => {
     ]);
     createAxiosHeadersMock.mockReturnValue('some header');
 
-    const result = await getTableNames();
+    const result = await getTableNames(mockTablesServerContext);
 
     expect(result[0]).toBe('table name 1');
     expect(result[1]).toBe('table name 2');
@@ -81,7 +77,7 @@ describe('get table names', () => {
     ]);
     createAxiosHeadersMock.mockReturnValue('some header');
 
-    const result = await getTableNames();
+    const result = await getTableNames(mockTablesServerContext);
 
     expect(result).toStrictEqual(['table name', 'table name2', 'table name3']);
     expect(makeOpenOpsTablesGetMock).toBeCalledTimes(1);
@@ -104,7 +100,7 @@ describe('get table names', () => {
     ]);
     createAxiosHeadersMock.mockReturnValue('some header');
 
-    const result = await getTableNames();
+    const result = await getTableNames(mockTablesServerContext);
 
     expect(result).toStrictEqual(['table name', 'table name3', 'Table Name']);
     expect(makeOpenOpsTablesGetMock).toBeCalledTimes(1);
@@ -203,7 +199,7 @@ describe('get table by table name', () => {
     ]);
     createAxiosHeadersMock.mockReturnValue('some header');
 
-    const result = await getTableByName('table name');
+    const result = await getTableByName('table name', mockTablesServerContext);
 
     expect(result).toStrictEqual({ id: 1, name: 'table name' });
     expect(makeOpenOpsTablesGetMock).toBeCalledTimes(1);
@@ -219,7 +215,7 @@ describe('get table by table name', () => {
     makeOpenOpsTablesGetMock.mockResolvedValue([{ id: 1, name: 'table name' }]);
     createAxiosHeadersMock.mockReturnValue('some header');
 
-    const result = await getTableByName('table name1');
+    const result = await getTableByName('table name1', mockTablesServerContext);
 
     expect(result).toBe(undefined);
     expect(makeOpenOpsTablesGetMock).toBeCalledTimes(1);
@@ -239,7 +235,7 @@ describe('get table by table name', () => {
     ]);
     createAxiosHeadersMock.mockReturnValue('some header');
 
-    const result = await getTableByName('table name');
+    const result = await getTableByName('table name', mockTablesServerContext);
 
     expect(result).toStrictEqual({ id: 1, name: 'table name' });
     expect(makeOpenOpsTablesGetMock).toBeCalledTimes(1);

packages/server/api/src/app/ai/mcp/llm-query-router.ts

@@ -3,6 +3,7 @@ import { logger } from '@openops/server-shared';
 import { AiConfigParsed, ChatFlowContext } from '@openops/shared';
 import { generateObject, LanguageModel, ModelMessage, ToolSet } from 'ai';
 import { z } from 'zod';
+import { projectService } from '../../project/project-service';
 import { getChatTools } from '../chat/ai-chat.service';
 import { buildUIContextSection } from '../chat/prompts.service';
 import { getAdditionalQueryClassificationDescriptions } from './extensions';
@@ -107,7 +108,7 @@ export async function routeQuery({
   }));
 
   try {
-    const openopsTablesNames = await getOpenOpsTablesNames();
+    const openopsTablesNames = await getOpenOpsTablesNames(projectId);
 
     const { object: selectionResult } = await generateObject({
       model: languageModel,
@@ -178,9 +179,13 @@ const getPreviousToolsForChat = async (
   }
 };
 
-const getOpenOpsTablesNames = async (): Promise<string[]> => {
+const getOpenOpsTablesNames = async (projectId: string): Promise<string[]> => {
   try {
-    return await getTableNames();
+    const project = await projectService.getOneOrThrow(projectId);
+    return await getTableNames({
+      tablesDatabaseId: project.tablesDatabaseId,
+      tablesDatabaseToken: project.tablesDatabaseToken,
+    });
   } catch (error) {
     logger.error('Error getting OpenOps table names for the LLM query router', {
       error,

packages/server/api/src/app/database/seeds/auto-instances-shutdown-table-seed.ts

@@ -4,6 +4,7 @@ import { FlagEntity } from '../../flags/flag.entity';
 import { SEED_OPENOPS_AUTO_INSTANCES_SHUTDOWN_TABLE_NAME } from '../../openops-tables/template-tables/create-auto-instances-shutdown-table';
 import { seedTemplateTablesService } from '../../openops-tables/template-tables/seed-tables-for-templates';
 import { databaseConnection } from '../database-connection';
+import { getDefaultProjectTablesDatabaseToken } from '../get-default-user-db-token';
 
 const AUTO_INSTANCES_SHUTDOWN_TABLE_SEED = 'AUTOINSTANCESSHUTDOWN';
 
@@ -34,6 +35,7 @@ export const seedAutoInstancesShutdownTable = async (): Promise<void> => {
 
   const table = await getTableByName(
     SEED_OPENOPS_AUTO_INSTANCES_SHUTDOWN_TABLE_NAME,
+    await getDefaultProjectTablesDatabaseToken(),
   );
 
   if (!table) {

packages/server/api/src/app/database/seeds/openops-aggregated-costs-seed.ts

@@ -4,6 +4,7 @@ import { FlagEntity } from '../../flags/flag.entity';
 import { SEED_TABLE_NAME } from '../../openops-tables/template-tables/create-aggregated-costs-table';
 import { seedTemplateTablesService } from '../../openops-tables/template-tables/seed-tables-for-templates';
 import { databaseConnection } from '../database-connection';
+import { getDefaultProjectTablesDatabaseToken } from '../get-default-user-db-token';
 
 const AGGREGATED_TABLE_SEED = 'AGGREGATEDCOSTS';
 
@@ -31,7 +32,10 @@ export const seedFocusDataAggregationTemplateTable =
       return;
     }
 
-    const table = await getTableByName(SEED_TABLE_NAME);
+    const table = await getTableByName(
+      SEED_TABLE_NAME,
+      await getDefaultProjectTablesDatabaseToken(),
+    );
 
     if (!table) {
       await seedTemplateTablesService.createAggregatedCostsTable();

packages/server/api/src/app/database/seeds/openops-delete-old-opportunities-table.ts

@@ -10,6 +10,7 @@ import { logger } from '@openops/server-shared';
 import { FlagEntity } from '../../flags/flag.entity';
 import { SEED_OPENOPS_TABLE_NAME } from '../../openops-tables/template-tables/create-opportunities-table';
 import { databaseConnection } from '../database-connection';
+import { getDefaultProjectTablesDatabaseToken } from '../get-default-user-db-token';
 
 const OPENOPS_OLD_OPPORTUNITIES_TABLE_DELETED = 'OPPORTUNITYDEL1';
 
@@ -54,7 +55,10 @@ export const deleteOldOpportunitiesTable = async (): Promise<void> => {
   try {
     const { token } = await authenticateDefaultUserInOpenOpsTables();
 
-    const table = await getTableByName(SEED_OPENOPS_TABLE_NAME);
+    const table = await getTableByName(
+      SEED_OPENOPS_TABLE_NAME,
+      await getDefaultProjectTablesDatabaseToken(),
+    );
     if (!table) {
       logger.info('Skip: OpenOps deletion of old opportunities table', {
         name: 'deleteOldOpportunitiesTable',

packages/server/api/src/app/database/seeds/openops-knonw-cost-types-by-application-seed.ts

@@ -4,6 +4,7 @@ import { FlagEntity } from '../../flags/flag.entity';
 import { SEED_OPENOPS_KNOWN_COST_TYPES_BY_APPLICATION_TABLE_NAME } from '../../openops-tables/template-tables/create-known-cost-types-by-application-table';
 import { seedTemplateTablesService } from '../../openops-tables/template-tables/seed-tables-for-templates';
 import { databaseConnection } from '../database-connection';
+import { getDefaultProjectTablesDatabaseToken } from '../get-default-user-db-token';
 
 const KNOWN_COST_TYPES_BY_APPLICATION = 'KNOWNCOSTTYPES';
 
@@ -34,6 +35,7 @@ export const seedKnownCostTypesByApplicationTable = async (): Promise<void> => {
 
   const table = await getTableByName(
     SEED_OPENOPS_KNOWN_COST_TYPES_BY_APPLICATION_TABLE_NAME,
+    await getDefaultProjectTablesDatabaseToken(),
   );
 
   if (!table) {

packages/server/api/src/app/database/seeds/openops-opportunities-table-seed.ts

@@ -4,6 +4,7 @@ import { FlagEntity } from '../../flags/flag.entity';
 import { SEED_OPENOPS_TABLE_NAME } from '../../openops-tables/template-tables/create-opportunities-table';
 import { seedTemplateTablesService } from '../../openops-tables/template-tables/seed-tables-for-templates';
 import { databaseConnection } from '../database-connection';
+import { getDefaultProjectTablesDatabaseToken } from '../get-default-user-db-token';
 
 const OPPORTUNITIES_TABLE_SEED = 'OPPORTUNITIESSEED';
 
@@ -32,7 +33,10 @@ export const seedOpportunitesTemplateTable = async (): Promise<void> => {
     return;
   }
 
-  const table = await getTableByName(SEED_OPENOPS_TABLE_NAME);
+  const table = await getTableByName(
+    SEED_OPENOPS_TABLE_NAME,
+    await getDefaultProjectTablesDatabaseToken(),
+  );
 
   if (!table) {
     await seedTemplateTablesService.createOpportunityTemplateTable();

packages/server/api/test/unit/mcp/llm-query-router.test.ts

@@ -23,6 +23,9 @@ jest.mock('ai', () => ({
 jest.mock('@openops/common', () => ({
   isLLMTelemetryEnabled: jest.fn().mockReturnValue(false),
   getTableNames: jest.fn().mockResolvedValue(['table1', 'table2', 'table3']),
+  getDatabaseTableNames: jest
+    .fn()
+    .mockResolvedValue(['table1', 'table2', 'table3']),
 }));
 
 jest.mock('@openops/server-shared', () => ({
@@ -34,12 +37,25 @@ jest.mock('@openops/server-shared', () => ({
     get: jest.fn().mockReturnValue('mock-value'),
     getBoolean: jest.fn().mockReturnValue(false),
   },
+  AppSystemProp: {
+    DB_TYPE: 'DB_TYPE',
+    ENABLE_TABLES_DATABASE_TOKEN: 'ENABLE_TABLES_DATABASE_TOKEN',
+  },
 }));
 
 jest.mock('../../../src/app/ai/chat/ai-chat.service', () => ({
   getChatTools: jest.fn(),
 }));
 
+jest.mock('../../../src/app/project/project-service', () => ({
+  projectService: {
+    getOneOrThrow: jest.fn().mockResolvedValue({
+      tablesDatabaseId: 1,
+      tablesDatabaseToken: 'mock-encrypted-token',
+    }),
+  },
+}));
+
 const getChatToolsMock = getChatTools as jest.Mock;
 
 describe('selectToolsAndQuery', () => {