Ensure we don't send strings in the error property (#1653)

Part of OPS-2843.

Author: maor-rozenfeld

packages/openops/src/lib/cloud-cli-common.ts

@@ -10,10 +10,12 @@ export function handleCliError({
   command: string;
   error: unknown;
 }): never {
-  logger.error(`${provider} CLI execution failed.`, {
-    command,
-    error,
-  });
+  logger.error(
+    `${provider} CLI execution failed.`,
+    error instanceof Error
+      ? { command, error }
+      : { command, errorMessage: error },
+  );
 
   const message = `An error occurred while running ${provider} CLI command: ${error}`;
 

packages/openops/src/lib/command-wrapper.ts

@@ -42,10 +42,10 @@ export async function executeFile(
 
 async function getResult(childProcess: ChildProcess, fullCommand: string) {
   let stdout = '';
-  let error = '';
+  let errorMessage = '';
 
   childProcess.stderr?.on('data', function (data) {
-    error += data;
+    errorMessage += data;
   });
 
   childProcess.stdout?.on('data', (data) => {
@@ -62,13 +62,13 @@ async function getResult(childProcess: ChildProcess, fullCommand: string) {
     command: fullCommand,
     exitCode,
     stdout,
-    error,
+    errorMessage,
   });
 
   return {
     exitCode: exitCode,
     stdOut: trimNewLines(stdout),
-    stdError: trimNewLines(error),
+    stdError: trimNewLines(errorMessage),
   };
 }