add Lukas as contributor, bump up version, polish news (#475)

Author: danielinteractive

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: mmrm
 Title: Mixed Models for Repeated Measures
-Version: 0.3.13.9001
+Version: 0.3.14
 Authors@R: c(
     person("Daniel", "Sabanes Bove", , "daniel.sabanes_bove@rconis.com", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0002-0176-9239")),
@@ -18,6 +18,8 @@ Authors@R: c(
     person("Daniel", "Leibovitz", , "daniel.leibovitz@roche.com", role = "aut"),
     person("Daniel D.", "Sjoberg", , "sjobergd@gene.com", role = "aut",
            comment = c(ORCID = "0000-0003-0862-2018")),
+    person("Lukas A.", "Widmer", , role = "ctb",
+           comment = c(ORCID = "0000-0003-1471-3493")),
     person("Boehringer Ingelheim Ltd.", role = c("cph", "fnd")),
     person("Gilead Sciences, Inc.", role = c("cph", "fnd")),
     person("F. Hoffmann-La Roche AG", role = c("cph", "fnd")),

NEWS.md

@@ -1,9 +1,9 @@
-# mmrm 0.3.13.9001
+# mmrm 0.3.14
 
 ### Bug Fixes
 
-- In version 0.3.13, when the tape optimizer from `TMB` was switched on, a warning would be given by `fit_mmrm()`, instructing users to turn off the tape optimizer. However, this is not necessary for reproducible results. Instead, it is now checked whether the deterministic hash for the TMB tape optimizer is used, and a warning is issued otherwise. 
-- In version 0.3.13, the above described warning by `fit_mmrm()` was not visible to the user when calling `mmrm()` because it was caught internally, causing the first fit in each session to fail for the first tried optimizer and falling back to the other optimizers. The warning is now issued directly by `mmrm()`. This change ensures that the first fit is consistent with subsequent fits, avoiding discrepancies observed in version 0.3.13.
+- In version 0.3.13, when the tape optimizer from `TMB` was switched on, a warning would be given by `fit_mmrm()`, instructing users to turn off the tape optimizer. However, this is not necessary for reproducible results. Instead, it is now checked whether the deterministic hash for the `TMB` tape optimizer is used, and a warning is issued otherwise. 
+- In version 0.3.13, the above described warning by `fit_mmrm()` was not visible to the user when calling `mmrm()` because it was caught internally, causing the first fit in each session to fail for the first tried optimizer and falling back to the other optimizers. The warning is now issued directly by `mmrm()`. This change ensures that the first model fit is consistent regarding the chosen optimizer (and thus numeric results) with subsequent model fits, avoiding discrepancies observed in version 0.3.13.
 
 # mmrm 0.3.13
 

R/utils.R

@@ -533,7 +533,7 @@ h_drop_levels <- function(data, subject_var, visit_var, except) {
 #' @return No return value, called for side effects.
 #' @keywords internal
 h_tmb_warn_non_deterministic <- function() {
-  if (packageVersion("TMB") < "1.9.15") {
+  if (utils::packageVersion("TMB") < "1.9.15") {
     return()
   }
   tmb_config <- TMB::config(DLL = "mmrm")

inst/WORDLIST

@@ -19,6 +19,7 @@ Indexible
 Ingelheim
 Kenward
 LDL
+Lukas
 MMRMs
 MacOS
 Mallinckrodt

man/mmrm-package.Rd

@@ -326,7 +326,7 @@ test_that("h_drop_levels works as expected", {
 # h_tmb_warn_non_deterministic ----
 
 test_that("h_tmb_warn_non_deterministic works as expected", {
-  skip_if(packageVersion("TMB") < "1.9.15")
+  skip_if(utils::packageVersion("TMB") < "1.9.15")
   TMB::config(tmbad_deterministic_hash = 0, DLL = "mmrm")
   expect_warning(
     h_tmb_warn_non_deterministic(),