Skip to content

Use session_dir_finalize to preserve output files #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhc54 merged 1 commit into from
Jan 18, 2026
Merged

Use session_dir_finalize to preserve output files #2379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/prted/prte.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1541,7 +1541,7 @@ static void abort_signal_callback(int fd)
second = false;
} else {
surekill(); // ensure we attempt to kill everything
pmix_os_dirpath_destroy(prte_process_info.top_session_dir, true, NULL);
prte_job_session_dir_finalize(NULL);
exit(1);
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/runtime/prte_finalize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
#include "src/runtime/runtime.h"
#include "src/util/name_fns.h"
#include "src/util/proc_info.h"
#include "src/util/session_dir.h"

int prte_finalize(void)
{
Expand Down Expand Up @@ -79,7 +80,7 @@ int prte_finalize(void)
prte_finalizing = true;

// we always must cleanup the session directory tree
pmix_os_dirpath_destroy(prte_process_info.top_session_dir, true, NULL);
prte_job_session_dir_finalize(NULL);

#ifdef PRTE_PICKY_COMPILERS
/* release the cache */
Expand Down
3 changes: 2 additions & 1 deletion src/util/session_dir.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* Copyright (c) 2015 Research Organization for Information Science
* and Technology (RIST). All rights reserved.
* Copyright (c) 2015-2020 Intel, Inc. All rights reserved.
* Copyright (c) 2021-2025 Nanook Consulting All rights reserved.
* Copyright (c) 2021-2026 Nanook Consulting All rights reserved.
* $COPYRIGHT$
*
* Additional copyrights may follow
Expand Down Expand Up @@ -293,6 +293,7 @@ void prte_job_session_dir_finalize(prte_job_t *jdata)
if (prte_finalizing) {
if (NULL != prte_process_info.top_session_dir) {
pmix_os_dirpath_destroy(prte_process_info.top_session_dir, true, _check_file);
/* if the top session dir is now empty, remove it */
rmdir(prte_process_info.top_session_dir);
free(prte_process_info.top_session_dir);
prte_process_info.top_session_dir = NULL;
Expand Down
Loading