Minor cleanups

Author: veniware

Protest/Database/ContactsJsonConverter.cs

@@ -44,13 +44,13 @@ public override void Write(Utf8JsonWriter writer, Database value, JsonSerializer
 
             writer.WriteStartObject();
 
-            if (title?.value?.Length > 0)      writer.WriteString(_title, title?.value ?? String.Empty);
-            if (name?.Length > 0)             writer.WriteString(_name, name);
-            if (department?.value?.Length > 0) writer.WriteString(_department, department?.value ?? String.Empty);
+            if (title?.value?.Length > 0)      writer.WriteString(_title, title.value);
+            if (name?.Length > 0)              writer.WriteString(_name, name);
+            if (department?.value?.Length > 0) writer.WriteString(_department, department.value);
 
-            if (email?.value?.Length > 0)           writer.WriteString(_email, email?.value ?? String.Empty);
-            if (telephoneNumber?.value?.Length > 0) writer.WriteString(_telephone, telephoneNumber?.value ?? String.Empty);
-            if (mobileNumber?.value?.Length > 0)    writer.WriteString(_mobile, mobileNumber?.value ?? String.Empty);
+            if (email?.value?.Length > 0)           writer.WriteString(_email, email.value);
+            if (telephoneNumber?.value?.Length > 0) writer.WriteString(_telephone, telephoneNumber.value);
+            if (mobileNumber?.value?.Length > 0)    writer.WriteString(_mobile, mobileNumber.value);
 
             writer.WriteEndObject();
         }

Protest/Tasks/Issues.cs

@@ -624,7 +624,8 @@ public static bool CheckDiskSpaceLifeline(Database.Entry device, string host, ou
             double slope = (n * sumXY - sumX * sumY) / (n * sumX2 - sumX * sumX);
             double intercept = (sumY - slope * sumX) / n;
 
-            if (slope == 0d) { continue; }
+            //check if slop is close to 0
+            if (Math.Abs(slope) < 1e-9) continue;
 
             double currentTime = (double)(DateTimeOffset.UtcNow.ToUnixTimeMilliseconds() - firstTimestamp);
             double predictedTime = (DISK_SPACE_THRESHOLD - intercept) / slope;

Protest/Tools/IpDiscovery.cs

@@ -542,7 +542,7 @@ private static void ParseMdnsResponse(ConcurrentDictionary<string, HostEntry> di
                     else if (answer[j].type == Protocols.Dns.RecordType.SRV) {
                         string[] split = answer[j].answerString.Split(':');
                         if (split.Length >= 2) {
-                            hostname = split[0].EndsWith(".local") ? split[0][..^6] : hostname = split[0];
+                            hostname = split[0].EndsWith(".local") ? split[0][..^6] : split[0];
 
                             if (ushort.TryParse(split[1], out ushort port) && port > 0) {
                                 if (services.Length > 0) services.Append(',');

Protest/Tools/Topology.cs

@@ -73,7 +73,7 @@ internal static async void WebSocketHandler(HttpListenerContext ctx) {
         }
 
         string sessionId = ctx.Request.Cookies["sessionid"]?.Value ?? null;
-        string origin = IPAddress.IsLoopback(ctx.Request.RemoteEndPoint.Address) ? "loopback" : Auth.GetUsername(sessionId);
+        //string origin = IPAddress.IsLoopback(ctx.Request.RemoteEndPoint.Address) ? "loopback" : Auth.GetUsername(sessionId);
 
         byte[] buffer = new byte[1024];
         WebSocketReceiveResult targetResult = await ws.ReceiveAsync(new ArraySegment<byte>(buffer), CancellationToken.None);