LiveStats, fix reverse DNS check logic

Author: veniware

Protest/Tasks/Watchdog.cs

@@ -16,10 +16,10 @@
 namespace Protest.Tasks;
 
 internal static class Watchdog {
-    private const long WEEK_IN_TICKS = 6_048_000_000_000L;
+    private const long WEEK_IN_TICKS        = 6_048_000_000_000L;
     private const long FIVE_MINUTE_IN_TICKS = 3_000_000_000L;
-    private const long MINUTE_IN_TICKS = 600_000_000L;
-    private const int FIVE_MINUTE_IN_MILLI = 300_000;
+    private const long MINUTE_IN_TICKS      = 600_000_000L;
+    private const int FIVE_MINUTE_IN_MILLI  = 300_000;
 
     public enum WatcherType : byte {
         icmp,
@@ -296,8 +296,7 @@ private static short CheckHttp(Watcher watcher) {
                 int statusCode = (int)response.StatusCode;
                 int category = statusCode / 100 - 1;
 
-                if (watcher.httpstatus.Length < category)
-                    continue;
+                if (watcher.httpstatus.Length < category) continue;
 
                 if (watcher.httpstatus[category]) {
                     result = 0;
@@ -362,7 +361,7 @@ private static short CheckHttpKeyword(Watcher watcher) {
     }
 
     private static short CheckTls(Watcher watcher) {
-        short result = -1;
+        short result = short.MaxValue;
 
         using HttpClientHandler handler = new HttpClientHandler();
         handler.ServerCertificateCustomValidationCallback = (request, cert, chain, errors) => {
@@ -390,8 +389,7 @@ private static short CheckTls(Watcher watcher) {
             }
             catch { }
 
-            if (result == short.MaxValue)
-                continue;
+            if (result == short.MaxValue) continue;
             break;
         }
 
@@ -642,7 +640,7 @@ public static void SendSmtpNotification(Watcher watcher, Notification notificati
         switch (watcher.type) {
         case WatcherType.icmp:
             if (status < 0) {
-                body.Append($"<b>{watcher.target}</b> stoped responding to ICMP requests.");
+                body.Append($"<b>{watcher.target}</b> stopped responding to ICMP requests.");
             }
             else {
                 body.Append($"<b>{watcher.target}</b> is now responding to ICMP requests.");
@@ -651,7 +649,7 @@ public static void SendSmtpNotification(Watcher watcher, Notification notificati
 
         case WatcherType.tcp:
             if (status < 0) {
-                body.Append($"<b>{watcher.target}</b> stoped listening on TCP port {watcher.port}.");
+                body.Append($"<b>{watcher.target}</b> stopped listening on TCP port {watcher.port}.");
             }
             else {
                 body.Append($"<b>{watcher.target}</b> is now listening on TCP port {watcher.port}.");

Protest/Tools/LiveStats.cs

@@ -16,6 +16,7 @@
 using Lextm.SharpSnmpLib;
 
 using static Protest.Protocols.Snmp.Polling;
+using System.Net.Sockets;
 
 namespace Protest.Tools;
 
@@ -273,7 +274,7 @@ public static async void DeviceStats(HttpListenerContext ctx) {
                 catch { }
             }
 
-            if (String.IsNullOrEmpty(_hostname?.value) && String.IsNullOrEmpty(_ip?.value)) { //check reverse dns mismatch
+            if (!String.IsNullOrEmpty(_hostname?.value) && !String.IsNullOrEmpty(_ip?.value)) { //check reverse dns mismatch
                 string hostnameValue = _hostname?.value ?? string.Empty;
                 string[] hostnames = hostnameValue.Split(';').Select(o => o.Trim()).ToArray();
 
@@ -286,6 +287,7 @@ public static async void DeviceStats(HttpListenerContext ctx) {
                     try {
                         IPAddress[] reversed = System.Net.Dns.GetHostAddresses(hostnames[i]);
                         for (int j = 0; j < reversed.Length; j++) {
+                            if (reversed[i].AddressFamily != AddressFamily.InterNetwork) continue;
                             if (!ips.Contains(reversed[j].ToString())) {
                                 WsWriteText(ws, $"{{\"warning\":\"Reverse DNS mismatch: {Data.EscapeJsonText(reversed[j].ToString())}\",\"source\":\"DNS\"}}", mutex);
                                 break;