Skip to content

Commit afc02e6

Browse files
authored
Limit CompilationFailure to Severity::Error (#173)
Fixes a bug where remarks are turned into `QSSCompilationFailure` resulting in failed compilations.
1 parent 7804189 commit afc02e6

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

lib/API/api.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -503,9 +503,11 @@ diagEngineHandler(Diagnostic &diagnostic,
503503
qssc_severity = qssc::Severity::Info;
504504
}
505505
// emit diagnostic cast to void to discard result as it is not needed here
506-
(void)qssc::emitDiagnostic(std::move(diagnosticCb), qssc_severity,
507-
qssc::ErrorCategory::QSSCompilationFailure,
508-
diagnostic.str());
506+
if (qssc_severity == qssc::Severity::Error) {
507+
(void)qssc::emitDiagnostic(std::move(diagnosticCb), qssc_severity,
508+
qssc::ErrorCategory::QSSCompilationFailure,
509+
diagnostic.str());
510+
}
509511

510512
// emit to llvm::errs as well to mimic default handler
511513
diagnostic.getLocation().print(llvm::errs());

0 commit comments

Comments
 (0)