Skip to content

Commit c72b858

Browse files
authored
Remove function localization (#225)
This PR removes function localization. These were capabilities that were initially added during prototyping and were ultimately not expanded on. They are currently just adding compilation time and in the future, if these capabilities are required will likely be implemented differently.
1 parent 4bbd0ac commit c72b858

File tree

6 files changed

+5
-550
lines changed

6 files changed

+5
-550
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
fixes:
3+
- |
4+
Remove function localization pass as this is not being used for any
5+
compilation features as was initially planned.

targets/systems/mock/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ qssc_add_plugin(QSSCTargetMock QSSC_TARGET_PLUGIN
3939
Conversion/QUIRToStandard/QUIRToStandard.cpp
4040
MockTarget.cpp
4141
MockUtils.cpp
42-
Transforms/FunctionLocalization.cpp
4342
Transforms/QubitLocalization.cpp
4443

4544
ADDITIONAL_HEADER_DIRS

targets/systems/mock/MockTarget.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
#include "HAL/TargetSystem.h"
2828
#include "HAL/TargetSystemRegistry.h"
2929
#include "Payload/Payload.h"
30-
#include "Transforms/FunctionLocalization.h"
3130
#include "Transforms/QubitLocalization.h"
3231

3332
#include "mlir/Dialect/LLVMIR/Transforms/LegalizeForExport.h"
@@ -184,7 +183,6 @@ MockSystem::MockSystem(std::unique_ptr<MockConfig> config)
184183
} // MockSystem
185184

186185
llvm::Error MockSystem::registerTargetPasses() {
187-
mlir::PassRegistration<MockFunctionLocalizationPass>();
188186
mlir::PassRegistration<MockQubitLocalizationPass>();
189187
mlir::PassRegistration<conversion::MockQUIRToStdPass>(
190188
[]() -> std::unique_ptr<conversion::MockQUIRToStdPass> {
@@ -203,9 +201,7 @@ void mockPipelineBuilder(mlir::OpPassManager &pm) {
203201
pm.addPass(std::make_unique<mlir::quir::RemoveQubitOperandsPass>());
204202
pm.addPass(std::make_unique<mlir::quir::ClassicalOnlyDetectionPass>());
205203
pm.addPass(std::make_unique<MockQubitLocalizationPass>());
206-
pm.addPass(std::make_unique<SymbolTableBuildPass>());
207204
OpPassManager &nestedModulePM = pm.nest<ModuleOp>();
208-
nestedModulePM.addPass(std::make_unique<MockFunctionLocalizationPass>());
209205
nestedModulePM.addPass(
210206
std::make_unique<mlir::quir::FunctionArgumentSpecializationPass>());
211207
} // mockPipelineBuilder

0 commit comments

Comments
 (0)