Improve cli (only allow unknown arguments after --)

Author: medihack

adit_radis_shared/cli/setup.py

@@ -0,0 +1,27 @@
+import argparse
+import sys
+
+import argcomplete
+
+
+def setup_root_parser(root_parser: argparse.ArgumentParser):
+    args = sys.argv[1:]
+    if "--" in args:
+        idx = args.index("--")
+        pre_args = args[:idx]
+        post_args = args[idx + 1 :]
+    else:
+        pre_args = args
+        post_args = []
+
+    argcomplete.autocomplete(root_parser)
+    args, unknown_args = root_parser.parse_known_args(pre_args)
+
+    if unknown_args:
+        root_parser.error(f"Unknown arguments before '--': {unknown_args}")
+
+    if not args.command:
+        root_parser.print_help()
+        sys.exit(1)
+
+    args.func(**vars(args), extra_args=post_args)

cli.py

@@ -5,10 +5,9 @@
 import shutil
 import sys
 
-import argcomplete
-
 from adit_radis_shared.cli import helper as cli_helper
 from adit_radis_shared.cli import parsers
+from adit_radis_shared.cli.setup import setup_root_parser
 
 
 def copy_statics(**kwargs):
@@ -69,10 +68,4 @@ def copy_file(file: str, filename: str | None = None):
     parser = subparsers.add_parser("copy_statics", help="Copy statics for the project")
     parser.set_defaults(func=copy_statics)
 
-    argcomplete.autocomplete(root_parser)
-    args, extra_args = root_parser.parse_known_args()
-    if not args.command:
-        root_parser.print_help()
-        sys.exit(1)
-
-    args.func(**vars(args), extra_args=extra_args)
+    setup_root_parser(root_parser)