Skip to content

Commit d95d27d

Browse files
1 parent e5f733c commit d95d27d

File tree

2 files changed

+46
-44
lines changed

2 files changed

+46
-44
lines changed

src/main/resources/META-INF/rewrite/examples.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ examples:
5656
type: specs.openrewrite.org/v1beta/example
5757
recipeName: org.openrewrite.java.dependencies.DependencyInsight
5858
examples:
59-
- description: ''
59+
- description: '`DependencyInsightTest#maven`'
6060
parameters:
6161
- org.springframework*
6262
- '*'
@@ -97,7 +97,7 @@ examples:
9797
type: specs.openrewrite.org/v1beta/example
9898
recipeName: org.openrewrite.java.dependencies.DependencyResolutionDiagnostic
9999
examples:
100-
- description: ''
100+
- description: '`DependencyResolutionDiagnosticTest#gradleNoMarker`'
101101
parameters:
102102
- 'null'
103103
- 'null'
@@ -117,7 +117,7 @@ examples:
117117
type: specs.openrewrite.org/v1beta/example
118118
recipeName: org.openrewrite.java.dependencies.FindDependency
119119
examples:
120-
- description: ''
120+
- description: '`FindDependencyTest#findMavenDependency`'
121121
parameters:
122122
- org.openrewrite
123123
- rewrite-core
@@ -157,7 +157,7 @@ examples:
157157
type: specs.openrewrite.org/v1beta/example
158158
recipeName: org.openrewrite.java.dependencies.RelocatedDependencyCheck
159159
examples:
160-
- description: ''
160+
- description: '`Maven#findRelocatedMavenDependencies`'
161161
parameters:
162162
- 'null'
163163
sources:
@@ -287,7 +287,7 @@ examples:
287287
type: specs.openrewrite.org/v1beta/example
288288
recipeName: org.openrewrite.java.dependencies.search.DoesNotIncludeDependency
289289
examples:
290-
- description: ''
290+
- description: '`DoesNotIncludeDependencyTest#whenDoesNotIncludeDependencyInCorrectScopeOrConfigurationMarks`'
291291
parameters:
292292
- org.springframework
293293
- spring-beans
@@ -351,7 +351,7 @@ examples:
351351
type: specs.openrewrite.org/v1beta/example
352352
recipeName: org.openrewrite.java.dependencies.search.FindMinimumDependencyVersion
353353
examples:
354-
- description: ''
354+
- description: '`FindMinimumDependencyVersionTest#minimumMaven`'
355355
parameters:
356356
- com.fasterxml.jackson*
357357
- jackson-core

src/test/java/org/openrewrite/java/dependencies/AddDependencyTest.java

Lines changed: 40 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import org.junit.jupiter.api.Test;
2121
import org.junit.jupiter.params.ParameterizedTest;
2222
import org.junit.jupiter.params.provider.ValueSource;
23+
import org.openrewrite.DocumentExample;
2324
import org.openrewrite.java.JavaParser;
2425
import org.openrewrite.test.RecipeSpec;
2526
import org.openrewrite.test.RewriteTest;
@@ -46,44 +47,7 @@ boolean getMap() {
4647
}
4748
""";
4849

49-
@ParameterizedTest
50-
@ValueSource(strings = {"com.google.common.math.*", "com.google.common.math.IntMath"})
51-
void addGradleDependencyWithOnlyIfUsingTestScope(String onlyIfUsing) {
52-
rewriteRun(
53-
spec -> spec.beforeRecipe(withToolingApi()).recipe(addDependency("com.google.guava:guava:29.0-jre", onlyIfUsing, null)),
54-
mavenProject("project",
55-
srcTestJava(
56-
java(usingGuavaIntMath)
57-
),
58-
//language=groovy
59-
buildGradle(
60-
"""
61-
plugins {
62-
id "java-library"
63-
}
64-
65-
repositories {
66-
mavenCentral()
67-
}
68-
""",
69-
"""
70-
plugins {
71-
id "java-library"
72-
}
73-
74-
repositories {
75-
mavenCentral()
76-
}
77-
78-
dependencies {
79-
testImplementation "com.google.guava:guava:29.0-jre"
80-
}
81-
"""
82-
)
83-
)
84-
);
85-
}
86-
50+
@DocumentExample
8751
@Test
8852
void addMavenDependencyWithSystemScope() {
8953
rewriteRun(
@@ -122,6 +86,44 @@ void addMavenDependencyWithSystemScope() {
12286
);
12387
}
12488

89+
@ParameterizedTest
90+
@ValueSource(strings = {"com.google.common.math.*", "com.google.common.math.IntMath"})
91+
void addGradleDependencyWithOnlyIfUsingTestScope(String onlyIfUsing) {
92+
rewriteRun(
93+
spec -> spec.beforeRecipe(withToolingApi()).recipe(addDependency("com.google.guava:guava:29.0-jre", onlyIfUsing, null)),
94+
mavenProject("project",
95+
srcTestJava(
96+
java(usingGuavaIntMath)
97+
),
98+
//language=groovy
99+
buildGradle(
100+
"""
101+
plugins {
102+
id "java-library"
103+
}
104+
105+
repositories {
106+
mavenCentral()
107+
}
108+
""",
109+
"""
110+
plugins {
111+
id "java-library"
112+
}
113+
114+
repositories {
115+
mavenCentral()
116+
}
117+
118+
dependencies {
119+
testImplementation "com.google.guava:guava:29.0-jre"
120+
}
121+
"""
122+
)
123+
)
124+
);
125+
}
126+
125127

126128
private AddDependency addDependency(String gav, String onlyIfUsing, @Nullable String scope) {
127129
String[] gavParts = gav.split(":");

0 commit comments

Comments
 (0)