OpenRewrite recipe best practices

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPractices?organizationId=QUxML01vZGVybmUvTW9kZXJuZSArIE9wZW5SZXdyaXRl

Co-authored-by: Moderne <[email protected]>

Author: timtebeek

src/main/resources/META-INF/rewrite/examples.yml

@@ -391,54 +391,54 @@ examples:
 type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.logging.log4j.ConvertJulEntering
 examples:
-  - description: '`ConvertJulEnteringTest#enteringToTraceEntry`'
-    sources:
-      - before: |
-          import java.util.logging.Logger;
-
-          class Test {
-              void method(Logger logger) {
-                logger.entering("Test", "method");
-                logger.entering("Test", "method", "param");
-                logger.entering("Test", "method", new Object[]{"param1", "param2"});
-              }
+- description: '`ConvertJulEnteringTest#enteringToTraceEntry`'
+  sources:
+  - before: |
+      import java.util.logging.Logger; // ChangeType will handle import
+
+      class Test {
+          void method(Logger logger) {
+            logger.entering("Test", "method");
+            logger.entering("Test", "method", "param");
+            logger.entering("Test", "method", new Object[]{"param1", "param2"});
           }
-        after: |
-          import java.util.logging.Logger;
+      }
+    after: |
+      import java.util.logging.Logger; // ChangeType will handle import
 
-          class Test {
-              void method(Logger logger) {
-                logger.traceEntry();
-                logger.traceEntry(null, "param");
-                logger.traceEntry(null, new Object[]{"param1", "param2"});
-              }
+      class Test {
+          void method(Logger logger) {
+            logger.traceEntry();
+            logger.traceEntry(null, "param");
+            logger.traceEntry(null, new Object[]{"param1", "param2"});
           }
-        language: java
+      }
+    language: java
 ---
 type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.logging.log4j.ConvertJulExiting
 examples:
-  - description: '`ConvertJulExitingTest#exitingToTraceExit`'
-    sources:
-      - before: |
-          import java.util.logging.Logger;
-
-          class Test {
-              void method(Logger logger) {
-                logger.exiting("Test", "method");
-                logger.exiting("Test", "method", "result");
-              }
+- description: '`ConvertJulExitingTest#exitingToTraceExit`'
+  sources:
+  - before: |
+      import java.util.logging.Logger; // ChangeType will handle import
+
+      class Test {
+          void method(Logger logger) {
+            logger.exiting("Test", "method");
+            logger.exiting("Test", "method", "result");
           }
-        after: |
-          import java.util.logging.Logger;
+      }
+    after: |
+      import java.util.logging.Logger; // ChangeType will handle import
 
-          class Test {
-              void method(Logger logger) {
-                logger.traceExit();
-                logger.traceExit("result");
-              }
+      class Test {
+          void method(Logger logger) {
+            logger.traceExit();
+            logger.traceExit("result");
           }
-        language: java
+      }
+    language: java
 ---
 type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.logging.log4j.JulToLog4j

src/test/java/org/openrewrite/java/logging/log4j/ConvertJulEnteringTest.java

@@ -18,7 +18,6 @@
 import org.junit.jupiter.api.Test;
 import org.openrewrite.DocumentExample;
 import org.openrewrite.InMemoryExecutionContext;
-import org.openrewrite.java.ChangeType;
 import org.openrewrite.java.JavaParser;
 import org.openrewrite.test.RecipeSpec;
 import org.openrewrite.test.RewriteTest;

src/test/java/org/openrewrite/java/logging/log4j/ConvertJulExitingTest.java

@@ -18,7 +18,6 @@
 import org.junit.jupiter.api.Test;
 import org.openrewrite.DocumentExample;
 import org.openrewrite.InMemoryExecutionContext;
-import org.openrewrite.java.ChangeType;
 import org.openrewrite.java.JavaParser;
 import org.openrewrite.test.RecipeSpec;
 import org.openrewrite.test.RewriteTest;