OpenRewrite recipe best practices

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPractices?organizationId=QUxML01vZGVybmUvTW9kZXJuZSArIE9wZW5SZXdyaXRl

Co-authored-by: Moderne <team@moderne.io>

Author: timtebeek

src/main/java/org/openrewrite/maven/MavenMojoProjectParser.java

@@ -41,6 +41,7 @@
 import org.openrewrite.PathUtils;
 import org.openrewrite.SourceFile;
 import org.openrewrite.groovy.GroovyParser;
+import org.openrewrite.internal.GitIgnore;
 import org.openrewrite.internal.StringUtils;
 import org.openrewrite.ipc.http.HttpUrlConnectionSender;
 import org.openrewrite.java.JavaParser;
@@ -49,7 +50,6 @@
 import org.openrewrite.java.marker.JavaSourceSet;
 import org.openrewrite.java.marker.JavaVersion;
 import org.openrewrite.jgit.api.Git;
-import org.openrewrite.internal.GitIgnore;
 import org.openrewrite.jgit.lib.ObjectId;
 import org.openrewrite.jgit.revwalk.RevCommit;
 import org.openrewrite.jgit.revwalk.RevWalk;

src/test/java/org/openrewrite/maven/MavenMojoProjectParserIsExcludedTest.java

@@ -25,10 +25,10 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.PathMatcher;
-import java.nio.file.Paths;
 import java.util.Collection;
-import java.util.Collections;
 
+import static java.util.Collections.emptyList;
+import static java.util.Collections.singletonList;
 import static org.assertj.core.api.Assertions.assertThat;
 
 /**
@@ -52,7 +52,7 @@ void untrackedGitIgnoredFileIsExcluded(@TempDir Path tempDir) throws Exception {
             git.add().addFilepattern(".gitignore").call();
             git.commit().setMessage("initial").call();
 
-            assertThat(MavenMojoProjectParser.isExcluded(repo, Collections.emptyList(), Paths.get("generated.txt")))
+            assertThat(MavenMojoProjectParser.isExcluded(repo, emptyList(), Path.of("generated.txt")))
                     .as("untracked gitignored file should be excluded")
                     .isTrue();
         }
@@ -71,7 +71,7 @@ void trackedGitIgnoredFileIsNotExcluded(@TempDir Path tempDir) throws Exception
             git.add().addFilepattern(".gitignore").call();
             git.commit().setMessage("add gitignore").call();
 
-            assertThat(MavenMojoProjectParser.isExcluded(repo, Collections.emptyList(), Paths.get("tracked-ignored.txt")))
+            assertThat(MavenMojoProjectParser.isExcluded(repo, emptyList(), Path.of("tracked-ignored.txt")))
                     .as("tracked gitignored file should NOT be excluded")
                     .isFalse();
         }
@@ -88,7 +88,7 @@ void untrackedFileInGitIgnoredDirectoryIsExcluded(@TempDir Path tempDir) throws
             git.add().addFilepattern(".gitignore").call();
             git.commit().setMessage("initial").call();
 
-            assertThat(MavenMojoProjectParser.isExcluded(repo, Collections.emptyList(), Paths.get("target/output.txt")))
+            assertThat(MavenMojoProjectParser.isExcluded(repo, emptyList(), Path.of("target/output.txt")))
                     .as("untracked file in gitignored directory should be excluded")
                     .isTrue();
         }
@@ -107,28 +107,28 @@ void trackedFileInGitIgnoredDirectoryIsNotExcluded(@TempDir Path tempDir) throws
             git.add().addFilepattern(".gitignore").call();
             git.commit().setMessage("add gitignore").call();
 
-            assertThat(MavenMojoProjectParser.isExcluded(repo, Collections.emptyList(), Paths.get("target/output.txt")))
+            assertThat(MavenMojoProjectParser.isExcluded(repo, emptyList(), Path.of("target/output.txt")))
                     .as("tracked file in gitignored directory should NOT be excluded")
                     .isFalse();
         }
     }
 
     @Test
     void exclusionMatcherMatchesDirectly() {
-        Collection<PathMatcher> matchers = Collections.singletonList(
+        Collection<PathMatcher> matchers = singletonList(
                 FileSystems.getDefault().getPathMatcher("glob:**/secret.properties"));
 
-        assertThat(MavenMojoProjectParser.isExcluded(null, matchers, Paths.get("config/secret.properties")))
+        assertThat(MavenMojoProjectParser.isExcluded(null, matchers, Path.of("config/secret.properties")))
                 .as("path matching exclusion pattern should be excluded")
                 .isTrue();
     }
 
     @Test
     void exclusionMatcherDoesNotMatchUnrelatedPath() {
-        Collection<PathMatcher> matchers = Collections.singletonList(
+        Collection<PathMatcher> matchers = singletonList(
                 FileSystems.getDefault().getPathMatcher("glob:**/secret.properties"));
 
-        assertThat(MavenMojoProjectParser.isExcluded(null, matchers, Paths.get("config/application.properties")))
+        assertThat(MavenMojoProjectParser.isExcluded(null, matchers, Path.of("config/application.properties")))
                 .as("path not matching exclusion pattern should not be excluded")
                 .isFalse();
     }
@@ -137,10 +137,10 @@ void exclusionMatcherDoesNotMatchUnrelatedPath() {
     void exclusionMatcherMatchesRootFileViaPrefixedSlash() {
         // PathMatcher won't match "pom.xml" against "**/pom.xml" without a leading slash;
         // isExcluded handles this by re-checking with a "/" prefix for relative paths
-        Collection<PathMatcher> matchers = Collections.singletonList(
+        Collection<PathMatcher> matchers = singletonList(
                 FileSystems.getDefault().getPathMatcher("glob:**/pom.xml"));
 
-        assertThat(MavenMojoProjectParser.isExcluded(null, matchers, Paths.get("pom.xml")))
+        assertThat(MavenMojoProjectParser.isExcluded(null, matchers, Path.of("pom.xml")))
                 .as("root-level file should match **/pom.xml via leading-slash prefixing")
                 .isTrue();
     }
@@ -149,21 +149,21 @@ void exclusionMatcherMatchesRootFileViaPrefixedSlash() {
     void exclusionMatcherMatchesRootFileWithLeadingSlash() {
         // When the path already has a leading slash, it should match directly
         // without needing the prefixing logic
-        Collection<PathMatcher> matchers = Collections.singletonList(
+        Collection<PathMatcher> matchers = singletonList(
                 FileSystems.getDefault().getPathMatcher("glob:**/pom.xml"));
 
-        assertThat(MavenMojoProjectParser.isExcluded(null, matchers, Paths.get("/pom.xml")))
+        assertThat(MavenMojoProjectParser.isExcluded(null, matchers, Path.of("/pom.xml")))
                 .as("root-level file with leading slash should match **/pom.xml directly")
                 .isTrue();
     }
 
     @Test
     void exclusionMatcherMatchesSubdirFileWithoutPrefixing() {
         // A file in a subdirectory should match directly without needing the "/" prefix path
-        Collection<PathMatcher> matchers = Collections.singletonList(
+        Collection<PathMatcher> matchers = singletonList(
                 FileSystems.getDefault().getPathMatcher("glob:**/pom.xml"));
 
-        assertThat(MavenMojoProjectParser.isExcluded(null, matchers, Paths.get("module/pom.xml")))
+        assertThat(MavenMojoProjectParser.isExcluded(null, matchers, Path.of("module/pom.xml")))
                 .as("subdirectory file should match **/pom.xml directly")
                 .isTrue();
     }