Avoid test failures due to shared JavaTemplates

Author: timtebeek

src/main/java/org/openrewrite/java/migrate/util/ReplaceStreamCollectWithToList.java

@@ -84,9 +84,6 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
 
     @RequiredArgsConstructor
     private static final class ReplaceCollectorToListVisitor extends JavaIsoVisitor<ExecutionContext> {
-        private static final JavaTemplate template = JavaTemplate
-                .builder("#{any(java.util.stream.Stream)}.toList()")
-                .build();
         private final boolean convertToList;
 
         @Override
@@ -97,9 +94,10 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, Execu
             }
             Expression command = method.getArguments().get(0);
             if (COLLECT_TO_UNMODIFIABLE_LIST.matches(command) ||
-                convertToList && COLLECT_TO_LIST.matches(command)) {
+                    convertToList && COLLECT_TO_LIST.matches(command)) {
                 maybeRemoveImport("java.util.stream.Collectors");
-                J.MethodInvocation toList = template.apply(updateCursor(result), result.getCoordinates().replace(), result.getSelect());
+                J.MethodInvocation toList = JavaTemplate.apply("#{any(java.util.stream.Stream)}.toList()",
+                        updateCursor(result), result.getCoordinates().replace(), result.getSelect());
                 return toList.getPadding().withSelect(result.getPadding().getSelect());
             }
             return result;

src/test/java/org/openrewrite/java/migrate/joda/JodaTimeFlowSpecTest.java

@@ -16,6 +16,8 @@
 package org.openrewrite.java.migrate.joda;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.Execution;
+import org.junit.jupiter.api.parallel.ExecutionMode;
 import org.openrewrite.Cursor;
 import org.openrewrite.DocumentExample;
 import org.openrewrite.ExecutionContext;
@@ -37,6 +39,7 @@
 import static org.openrewrite.java.Assertions.java;
 import static org.openrewrite.test.RewriteTest.toRecipe;
 
+@Execution(ExecutionMode.SAME_THREAD)
 class JodaTimeFlowSpecTest implements RewriteTest {
     @Override
     public void defaults(RecipeSpec spec) {

src/test/java/org/openrewrite/java/migrate/joda/JodaTimeRecipeTest.java

@@ -16,13 +16,16 @@
 package org.openrewrite.java.migrate.joda;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.Execution;
+import org.junit.jupiter.api.parallel.ExecutionMode;
 import org.openrewrite.DocumentExample;
 import org.openrewrite.java.JavaParser;
 import org.openrewrite.test.RecipeSpec;
 import org.openrewrite.test.RewriteTest;
 
 import static org.openrewrite.java.Assertions.java;
 
+@Execution(ExecutionMode.SAME_THREAD)
 class JodaTimeRecipeTest implements RewriteTest {
     @Override
     public void defaults(RecipeSpec spec) {
@@ -223,7 +226,7 @@ public DateTime foo(String city) {
               import java.time.Duration;
               import java.time.ZoneId;
               import java.time.ZonedDateTime;
-              
+
               class A {
                    public ZonedDateTime foo(String city) {
                        ZoneId dtz;

src/test/java/org/openrewrite/java/migrate/joda/JodaTimeScannerTest.java

@@ -16,6 +16,8 @@
 package org.openrewrite.java.migrate.joda;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.Execution;
+import org.junit.jupiter.api.parallel.ExecutionMode;
 import org.openrewrite.java.JavaParser;
 import org.openrewrite.java.tree.J;
 import org.openrewrite.test.RecipeSpec;
@@ -29,6 +31,7 @@
 import static org.openrewrite.java.Assertions.java;
 import static org.openrewrite.test.RewriteTest.toRecipe;
 
+@Execution(ExecutionMode.SAME_THREAD)
 class JodaTimeScannerTest implements RewriteTest {
     @Override
     public void defaults(RecipeSpec spec) {
@@ -215,12 +218,12 @@ void detectUnsafeVarsInInitializer() {
               import java.util.stream.Collectors;
               import java.util.stream.Stream;
               import java.util.List;
-              
+
               class A {
                   public Period period() {
                       return new Period();
                   }
-              
+
                   public void foo() {
                       List<Integer> list = Stream.of(1, 2, 3).peek(i -> {
                             Period p1 = period();
@@ -251,12 +254,12 @@ void detectUnsafeVarsInChainedLambdaExpressions() {
               import java.util.stream.Collectors;
               import java.util.stream.Stream;
               import java.util.List;
-              
+
               class A {
                   public Period period() {
                       return new Period();
                   }
-              
+
                   public void foo() {
                       List<Integer> list = Stream.of(1, 2, 3).peek(i -> {
                             Period p1 = period();

src/test/java/org/openrewrite/java/migrate/joda/JodaTimeVisitorTest.java

@@ -16,6 +16,8 @@
 package org.openrewrite.java.migrate.joda;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.Execution;
+import org.junit.jupiter.api.parallel.ExecutionMode;
 import org.openrewrite.DocumentExample;
 import org.openrewrite.java.JavaParser;
 import org.openrewrite.test.RecipeSpec;
@@ -26,6 +28,7 @@
 import static org.openrewrite.java.Assertions.java;
 import static org.openrewrite.test.RewriteTest.toRecipe;
 
+@Execution(ExecutionMode.SAME_THREAD)
 class JodaTimeVisitorTest implements RewriteTest {
     @Override
     public void defaults(RecipeSpec spec) {