Skip to content

Commit 3ea3063

Browse files
committed
Polish FindInternalJavaxApis
1 parent 5a66684 commit 3ea3063

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/main/java/org/openrewrite/java/migrate/search/FindInternalJavaxApis.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,13 @@
2020
import org.jspecify.annotations.Nullable;
2121
import org.openrewrite.*;
2222
import org.openrewrite.internal.StringUtils;
23+
import org.openrewrite.java.TypeMatcher;
2324
import org.openrewrite.java.search.UsesType;
2425
import org.openrewrite.java.table.MethodCalls;
2526
import org.openrewrite.java.trait.MethodAccess;
2627
import org.openrewrite.java.tree.JavaType;
2728
import org.openrewrite.java.tree.MethodCall;
29+
import org.openrewrite.java.tree.TypeUtils;
2830
import org.openrewrite.marker.SearchResult;
2931

3032
import java.util.regex.Pattern;
@@ -58,7 +60,7 @@ public String getDescription() {
5860

5961
@Override
6062
public TreeVisitor<?, ExecutionContext> getVisitor() {
61-
Pattern javaxType = Pattern.compile(StringUtils.aspectjNameToPattern("javax..*"));
63+
TypeMatcher javaxType = new TypeMatcher("javax..*");
6264
return Preconditions.check(new UsesType<>("javax..*", null),
6365
(StringUtils.isBlank(methodPattern) ? new MethodAccess.Matcher() : new MethodAccess.Matcher(methodPattern))
6466
.asVisitor((ma, ctx) -> {
@@ -68,12 +70,12 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
6870
if (methodType == null || methodType.getReturnType() == null || methodType.getReturnType() instanceof JavaType.Unknown) {
6971
return call;
7072
}
71-
if (methodType.getReturnType().isAssignableFrom(javaxType)) {
73+
if (TypeUtils.isAssignableTo(javaxType::matches, methodType.getReturnType())) {
7274
insertRow(ma, ctx, methodType);
7375
return SearchResult.found(call);
7476
}
7577
for (JavaType parameterType : methodType.getParameterTypes()) {
76-
if (parameterType.isAssignableFrom(javaxType)) {
78+
if (TypeUtils.isAssignableTo(javaxType::matches, parameterType)) {
7779
insertRow(ma, ctx, methodType);
7880
return SearchResult.found(call);
7981
}

0 commit comments

Comments
 (0)