Skip to content

Commit 7592e24

Browse files
committed
Do not include UseEnumSetOf with chained Java upgrades
Fixes #958
1 parent 195efc5 commit 7592e24

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

src/main/java/org/openrewrite/java/migrate/util/UseEnumSetOf.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public String getDisplayName() {
5555

5656
@Override
5757
public String getDescription() {
58-
return "Prefer `EnumSet of(..)` instead of using `Set of(..)` when the arguments are enums in Java 5 or higher.";
58+
return "Prefer `EnumSet of(..)` instead of using `Set of(..)` when the arguments are enums in Java 9 or higher.";
5959
}
6060

6161
@Override

src/main/resources/META-INF/rewrite/java-version-11.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,10 @@ recipeList:
6565
- org.openrewrite.java.migrate.util.OptionalNotPresentToIsEmpty
6666
- org.openrewrite.java.migrate.util.OptionalNotEmptyToIsPresent
6767
- org.openrewrite.java.migrate.util.OptionalStreamRecipe
68+
# Disabled as too opinionated for general use
69+
# https://github.com/openrewrite/rewrite-migrate-java/issues/958
70+
# - org.openrewrite.java.migrate.util.UseEnumSetOf:
71+
# convertEmptySet: false
6872
- org.openrewrite.java.migrate.InternalBindPackages
6973
- org.openrewrite.java.migrate.RemovedSecurityManagerMethods
7074
- org.openrewrite.java.migrate.UpgradePluginsForJava11

src/main/resources/META-INF/rewrite/java-version-6.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ tags:
2525
- java6
2626
recipeList:
2727
- org.openrewrite.java.migrate.jacoco.UpgradeJaCoCo
28-
- org.openrewrite.java.migrate.util.UseEnumSetOf:
29-
convertEmptySet: false
3028
- org.openrewrite.java.migrate.JREWrapperInterface
3129
---
3230
type: specs.openrewrite.org/v1beta/recipe

0 commit comments

Comments
 (0)